Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sticky pinned tabs by default to improve vertical scrolling #30761

Closed
sangwoo108 opened this issue Jun 2, 2023 · 1 comment · Fixed by brave/brave-core#18724
Closed
Assignees

Comments

@sangwoo108
Copy link

sangwoo108 commented Jun 2, 2023

The default value was disabled. Now we think it's good to go.


Verification steps

@sangwoo108 sangwoo108 self-assigned this Jun 2, 2023
@sangwoo108 sangwoo108 added feature/vertical-tabs priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude QA/Yes and removed QA/No labels Jun 2, 2023
@rebron rebron added this to In progress in Front End Jun 6, 2023
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone Jun 7, 2023
@rebron rebron moved this from In progress to Pending review in Front End Jun 9, 2023
@rebron rebron moved this from Pending review to Completed in Front End Jun 13, 2023
@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA Pass-Win64 labels Jun 21, 2023
@MadhaviSeelam
Copy link
Collaborator

MadhaviSeelam commented Jun 21, 2023

Verification Passed using

Brave | 1.54.75 Chromium: 115.0.5790.32 (Official Build) beta (64-bit)
-- | --
Revision | f9b78cf410ecd5b372310ef25a12ef456c77d90f-refs/branch-heads/5790@{#724}
OS | Windows 11 Version 22H2 (Build 22621.1848)
  1. Install 1.54.75
  2. launch Brave
  3. clicked Set Brave as default Browser
  4. imported Profiles from Edge
  5. opened brave://flags
  6. verified #brave-vertical-tabs-stick-pinned-tabs is set to Default
  7. opened few tabs
  8. clicked to open https://www.cnbc.com bookmark
  9. right clicked on the tab to open context menu
  10. selected Use Vertical tabs
  11. verified vertical tabs panel is shown with all the open tabs in expanded mode
  12. selected Pin from the context menu for one of the tabs (i.e. cnbc.com)
  13. pin few more tabs
  14. scrolled thru unpinned tabs
  • confirmed cnbc.com tab is pinned
  • confirmed additional tabs pinned as expected
  • confirmed pinned tabs were sticky when scrolling thru unpinned tabs in expanded mode
  • confirmed pinned tabs were sticky when scrolling thru unpinned tabs in Float/mouseover mode
example example example example
image image image image
2023-06-21_18h11_50.mp4

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 3, 2023
@rebron rebron changed the title Enable sticky pinned tabs by default Enable sticky pinned tabs by default to improve vertical scrolling Aug 8, 2023
@rebron rebron removed this from Completed in Front End Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants