Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force aggressive cosmetic filtering on YouTube #30896

Closed
antonok-edm opened this issue Jun 7, 2023 · 6 comments · Fixed by brave/brave-core#18813
Closed

Force aggressive cosmetic filtering on YouTube #30896

antonok-edm opened this issue Jun 7, 2023 · 6 comments · Fixed by brave/brave-core#18813
Assignees
@antonok-edm
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/shields/adblock Blocking ads & trackers with Shields features/shields/cosmetic-filtering OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.58.x - Release

Comments

@antonok-edm
Copy link
Collaborator

#17607 applied aggressive cosmetic filtering mode for network blocking. We need to apply the same treatment to cosmetic filtering.
@antonok-edm antonok-edm added feature/shields/adblock Blocking ads & trackers with Shields QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality features/shields/cosmetic-filtering OS/Desktop labels Jun 7, 2023
@antonok-edm antonok-edm self-assigned this Jun 7, 2023
@antonok-edm antonok-edm mentioned this issue Jun 8, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Jul 8, 2023
@stephendonner
Copy link

stephendonner commented Aug 15, 2023 •
edited
Loading

Verification PASSED using

Brave | 1.58.89 Chromium: 116.0.5845.82 (Official Build) beta (x86_64)
-- | --
Revision | 178049e05b89fc5bcb71ae5d2af40e095246c2d4
OS | macOS Version 11.7.9 (Build 20G1426)

Steps:

  1. installed 1.58.89
  2. launched Brave
  3. loaded youtube.com
  4. found the YouTube Free with ads movies: https://www.youtube.com/feed/storefront?bp=ogUCKAY%3D
  5. played https://www.youtube.com/watch?v=YNef4VP6M5c (The Hunger Games)
  6. clicked on the shields icon, clicked Advanced Controls
  7. confirmed Block trackers & ads
  8. changed the player's seek position, to try to trigger ads
  9. changed shield's setting to Aggressively block trackers & ads
  10. loaded the youtube.com homepage, and generally clicked around for a while
  11. switched back to Block trackers & ads and clicked around
  12. finally, disabled shields and noted the ads

Confirmed:

  • no pre-roll or interstitial ads when viewing The Hunger Games with either:
    • Block trackers & ads (default) Brave Shields setting
    • Aggressively block trackers & ads setting
  • pre-roll, interstitial, and static (top-right) ads returned when Brave Shields was either disabled or set to Allow all trackers & ads

Ad-sponsored movie (The Hunger Games)

Block trackers & ads Aggressively block trackers & ads Brave Shields, down Allow all trackers & ads
Screen Shot 2023-08-15 at 3 02 20 PM Screen Shot 2023-08-15 at 3 04 12 PM Screen Shot 2023-08-15 at 3 11 58 PM Screen Shot 2023-08-15 at 4 33 57 PM

YouTube.com homepage

Shields, down Shields, Aggressively... Shields, Block trackers & ads
Screen Shot 2023-08-15 at 4 22 00 PM Screen Shot 2023-08-15 at 4 22 13 PM Screen Shot 2023-08-15 at 4 22 24 PM

@MadhaviSeelam
Copy link

MadhaviSeelam commented Aug 21, 2023 •
edited
Loading

Verification PASSED using

Brave | 1.58.96 Chromium: 116.0.5845.96 (Official Build) beta (64-bit)
-- | --
Revision | 153399f19fc2a3db55e64efb3ad06cb52d8a39fb
OS | Windows 11 Version 22H2 (Build 22621.2134)

Steps:

  1. installed 1.58.96
  2. launched Brave
  3. loaded youtube.com
  4. found and played YouTube Free with ads movies: https://www.youtube.com/watch?v=INWZNWBIqRY (The Big Trip)
  5. clicked on the Shields icon, clicked Advanced Controls
  6. confirmed Block trackers & ads
  7. changed the player's seek position, to try to trigger ads
  8. changed shield's setting to Aggressively block trackers & ads and movie reloaded and no ads are shown
  9. loaded the youtube.com homepage, and generally clicked around for a while
  10. switched to Allow all trackers and & ads and previously played video reloaded to show ads
  11. finally, disabled shields and noted the ads

Confirmed:

  • no pre-roll or interstitial ads when viewing The The Big Trip with either:
  • Block trackers & ads (default) Brave Shields setting
  • Aggressively block trackers & ads setting
  • pre-roll, interstitial, and static (top-right) ads returned when Brave Shields was either disabled or set to Allow all trackers & ads

Ad-sponsored movie (The Big Trip)

Block trackers & ads Aggressively block trackers & ads Allow all trackers & ads Brave Shields, down
image image image image

CNN.com

Block trackers & ads Aggressively block trackers & ads Allow all trackers & ads Brave Shields, down
image image image image

Youtube.com

Block trackers & ads Aggressively block trackers & ads Allow all trackers & ads Brave Shields, down
image image image image

@kjozwiak kjozwiak added the Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected label Aug 23, 2023
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 25, 2023
@stephendonner
Copy link

stephendonner commented Aug 25, 2023 •
edited
Loading

Verification PASSED using

Brave | 1.58.101 Chromium: 116.0.5845.114 (Official Build) beta (64-bit)
-- | --
Revision | f6b6f6271f9a51efe3c5e2be309f1a12012880c6
OS | Linux

Steps:

  1. installed 1.58.101
  2. launched Brave
  3. loaded youtube.com
  4. found and played YouTube Free with ads movies: https://www.youtube.com/watch?v=g1VYI-sQVwg (Spy Kids 2)
  5. clicked on the Shields icon, clicked Advanced Controls
  6. confirmed Block trackers & ads
  7. changed the player's seek position, to try to trigger ads
  8. changed shield's setting to Aggressively block trackers & ads and movie reloaded and no ads are shown
  9. loaded the youtube.com homepage, and generally clicked around for a while
  10. switched to Allow all trackers and & ads and previously-played video reloaded to show ads
  11. finally, disabled shields and noted the ads

Confirmed:

  • no pre-roll or interstitial ads when viewing Spy Kids 2 with either:
    • Block trackers & ads (default) Brave Shields setting
    • Aggressively block trackers & ads setting
  • pre-roll, interstitial, and static (top-right) ads returned when Brave Shields was either disabled or set to Allow all trackers & ads

Ad-sponsored movie (Spy Kids 2: The Island of Lost Dreams)

Block trackers & ads Aggressively block trackers & ads Allow all trackers & ads Brave Shields, down
Screen Shot 2023-08-25 at 2 21 40 PM Screen Shot 2023-08-25 at 2 23 22 PM Screen Shot 2023-08-25 at 2 29 28 PM Screen Shot 2023-08-25 at 2 26 57 PM

huffpost.com

Block trackers & ads Aggressively block trackers & ads Allow all trackers & ads Brave Shields, down
Screen Shot 2023-08-25 at 3 21 52 PM Screen Shot 2023-08-25 at 3 22 03 PM Screen Shot 2023-08-25 at 3 22 26 PM Screen Shot 2023-08-25 at 3 22 43 PM

YouTube.com

Block trackers & ads Aggressively block trackers & ads Allow all trackers & ads Brave Shields, down
Screen Shot 2023-08-25 at 3 10 05 PM Screen Shot 2023-08-25 at 3 10 40 PM Screen Shot 2023-08-25 at 3 12 17 PM Screen Shot 2023-08-25 at 3 12 41 PM

@stephendonner stephendonner added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 25, 2023
@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 8, 2023
@Uni-verse
Copy link
Contributor

Uni-verse commented Sep 8, 2023 •
edited
Loading

Verified on Samsung Galaxy S21 using version(s):

Brave	1.58.117 Chromium: 116.0.5845.180 (Official Build) (64-bit) 
Revision	99255ad6abf2fa399c063683c051f973e1f5c0af
OS	Android 13; Build/TP1A.220624.014; 33; REL

Test Plan: brave/brave-core#18813 (comment)

  • Ensured preroll ads and content ads are not shown on youtube.com when using Block trackers & ads & Aggressively block trackers & ads
  • Ensured bringing Shields down will disable ad blocking on youtube. Preroll and content ads will be shown
  • Ensured that setting Ad Block settings in shields panel to Allow all trackers & ads will display ads and preroll ads
Example Example Example Example
Screenshot 2023-09-08 at 11 56 50 AM Screenshot 2023-09-08 at 11 56 56 AM Screenshot 2023-09-08 at 11 57 45 AM Screenshot 2023-09-08 at 12 04 35 PM

@Uni-verse
Copy link
Contributor

Uni-verse commented Sep 8, 2023 •
edited
Loading

Verified on Samsung Tab S7 using version(s):

Brave	1.58.117 Chromium: 116.0.5845.180 (Official Build) (64-bit) 
Revision	99255ad6abf2fa399c063683c051f973e1f5c0af
OS	Android 13; Build/TP1A.220624.014; 33; REL

Test Plan: brave/brave-core#18813 (comment)

  • Ensured preroll ads and content ads are not shown on youtube.com when using Block trackers & ads & Aggressively block trackers & ads
  • Ensured bringing Shields down will disable ad blocking on youtube. Preroll and content ads will be shown
  • Ensured that setting Ad Block settings in shields panel to Allow all trackers & ads will display ads and preroll ads
Example Example Example
Screenshot 2023-09-08 at 1 55 18 PM Screenshot 2023-09-08 at 1 55 31 PM Screenshot 2023-09-08 at 1 58 44 PM

@Uni-verse
Copy link
Contributor

Verified on Pixel 2XL using version(s):

Brave	1.58.117 Chromium: 116.0.5845.180 (Official Build) (64-bit) 
Revision	99255ad6abf2fa399c063683c051f973e1f5c0af
OS	Android 8.1.0; Build/OPM2.171026.006.H1; 27; REL

Test Plan: brave/brave-core#18813 (comment)

  • Ensured preroll ads and content ads are not shown on youtube.com when using Block trackers & ads & Aggressively block trackers & ads
  • Ensured bringing Shields down will disable ad blocking on youtube. Preroll and content ads will be shown
  • Ensured that setting Ad Block settings in shields panel to Allow all trackers & ads will display ads and preroll ads
Example Example Example
Screenshot 2023-09-08 at 2 16 15 PM Screenshot 2023-09-08 at 2 16 59 PM Screenshot 2023-09-08 at 2 17 16 PM

@Uni-verse Uni-verse added QA Pass - Android 8+ and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 8, 2023
@LaurenWags LaurenWags mentioned this issue Sep 13, 2023
Closed
@kjozwiak kjozwiak mentioned this issue Sep 15, 2023
Closed
@kjozwiak kjozwiak mentioned this issue Sep 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonok-edm antonok-edm

Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/shields/adblock Blocking ads & trackers with Shields features/shields/cosmetic-filtering OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

Force aggressive cosmetic filtering on youtube brave/brave-core
7 participants
@stephendonner @kjozwiak @Uni-verse @antonok-edm @LaurenWags @brave-builds @MadhaviSeelam