Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical tabs hide animation results in favicons shifting rapidly #30897

Closed
petemill opened this issue Jun 7, 2023 · 5 comments · Fixed by brave/brave-core#18994
Closed

Vertical tabs hide animation results in favicons shifting rapidly #30897

petemill opened this issue Jun 7, 2023 · 5 comments · Fixed by brave/brave-core#18994

Comments

@petemill
Copy link
Member

petemill commented Jun 7, 2023

Description

When in minimized mode and un-hovering from the floating vertical tab strip, the favicons bounce a few pixels from side to side

Version 1.54.38
macOS

@sangwoo108
Copy link

I didn't dig much but I believe that's because sub components has a hard-coded insets based on the tab's width. IIRC, they don't interpolate the insets so the sub components could look like jumping back and forth.

@rebron rebron added feature/vertical-tabs priority/P4 Planned work. We expect to get to it "soon". labels Jun 9, 2023
@rebron rebron added this to On Deck in Front End Jun 13, 2023
@brave-builds brave-builds added this to the 1.55.x - Nightly milestone Jun 22, 2023
@rebron rebron moved this from On Deck to Completed in Front End Jul 11, 2023
@stephendonner
Copy link
Collaborator

Verified PASSED using

Brave 1.58.89 Chromium: 116.0.5845.82 (Official Build) beta (x86_64)
Revision 178049e05b89fc5bcb71ae5d2af40e095246c2d4
OS macOS Version 11.7.9 (Build 20G1426)

Steps:

  1. installed 1.58.89
  2. launched Brave
  3. enabled vertical tabs
  4. loaded a few sites
  5. clicked on the Expand tabs tab to collapse the panel
  6. hovered over each of the site favicons

Confirmed there is no longer a "bounce" or "wiggle" effect when hovering over and out of minimized tabs

1.58.89 1.54.38
icons-no-bouncing icons-bounce

@OptimusPrime-GIF
Copy link

The new version of vertical tabs don't appear in fullscreen. So not tab at all in fullscreen

@rebron rebron removed this from Completed in Front End Sep 15, 2023
@EtFX1
Copy link

EtFX1 commented Sep 19, 2023

The new version of vertical tabs don't appear in fullscreen. So not tab at all in fullscreen

good, so i know I'm not the only one.

@sangwoo108
Copy link

Hi, we'd removed vertical tab strip on fullscreen but decided to revert it as it's imperfect fix. Please refer to #33020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants