Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide/Unhide NFT's is making unnecessary price history calls #30925

Closed
Douglashdaniel opened this issue Jun 8, 2023 · 1 comment · Fixed by brave/brave-core#18828
Closed
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/No release-notes/include

Comments

@Douglashdaniel
Copy link

Description

Hide/Unhide NFT's is making unnecessary price history calls causing the Portfolio balance to change.

Steps to Reproduce

  1. Go to the NFT's tab and Hide/Unhide some nft's
  2. Price history will change sometimes.

Actual result:

Screen.Recording.7.mov

Expected result:

We shouldn't need to update price history when hiding or unhiding nft's

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@srirambv
Copy link
Contributor

@Douglashdaniel think this is still happening as the price change happens when I hide/unhide NFTs

brave_y1W2mPpruj.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/No release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants