Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate Accounts and Transactions in Assets details Screen #30981

Closed
Douglashdaniel opened this issue Jun 12, 2023 · 1 comment · Fixed by brave/brave-core#19092
Closed

Separate Accounts and Transactions in Assets details Screen #30981

Douglashdaniel opened this issue Jun 12, 2023 · 1 comment · Fixed by brave/brave-core#19092
Assignees
@Douglashdaniel
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.58.x - Release

Comments

@Douglashdaniel
Copy link

Description

We need to add a Segmented controller to the Asset Details screen to separate Accounts and Transactions.

Screenshot 27
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jun 12, 2023
@Douglashdaniel Douglashdaniel self-assigned this Jun 12, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Jun 28, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.55.x - Nightly milestone Jun 29, 2023
@srirambv
Copy link
Contributor

srirambv commented Sep 5, 2023

Verification passed on

Brave 1.58.114 Chromium: 116.0.5845.163 (Official Build) beta (64-bit)
Revision 21631edab5a70964c2f5817bfa4d06c32b4ab314
OS Windows 11 Version 22H2 (Build 22621.2215)
  • Verified steps from brave/brave-core#19092
  • Verified Accounts and Transactions routes work as expected for a token
30981.mp4

@LaurenWags LaurenWags mentioned this issue Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Portfolio Asset Segmented Controls brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds