Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Etherscan calls to new proxy #31079

Closed
nvonpentz opened this issue Jun 15, 2023 · 2 comments · Fixed by brave/brave-core#18972
Closed

Migrate Etherscan calls to new proxy #31079

nvonpentz opened this issue Jun 15, 2023 · 2 comments · Fixed by brave/brave-core#18972

Comments

@nvonpentz
Copy link
Member

nvonpentz commented Jun 15, 2023

We have new proxies deployed, so we should update the codebase to point to the new URLs. The response schema has changed slightly (no more wrapper with lastUpdated), so well need to update ParseTokenInfo incomponents/brave_wallet/browser/asset_ratio_response_parser.cc to parse the new response format.

Also we'll need to add the Brave Services Key if it's not included already.

@kjozwiak
Copy link
Member

kjozwiak commented Aug 7, 2023

@srirambv going to label this one as QA/Yes so we can quickly verify that the Stripe onramp is working as mentioned via brave/brave-core#19566 (comment). The above requires 1.57.41 or higher for 1.57.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Aug 9, 2023

Verified as part of #31397 (comment). Just ensured that Stripe option is shown only for US and when selecting a particular token and selecting Stripe loads the selected token and the input amount.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants