Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solana connect prompt should provide a list of available accounts for users to choose #31109

Closed
darkdh opened this issue Jun 16, 2023 · 3 comments · Fixed by brave/brave-core#19200
Closed

Solana connect prompt should provide a list of available accounts for users to choose #31109

darkdh opened this issue Jun 16, 2023 · 3 comments · Fixed by brave/brave-core#19200
Assignees
@darkdh
Labels
feature/web3/wallet/core feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.58.x - Release

Comments

@darkdh
Copy link
Member

darkdh commented Jun 16, 2023 •
edited
Loading

This report came from @mrose17 when integrating wallet with Brave Talk

Currently we only show the "selected" account despite the user has more than one SOL accounts
Screen Shot 2023-06-16 at 09 28 15

We should let user to choose which SOL account to connect and the account will be selected afterward if the user approve the request.
Note that the user can only choose "ONE" account in the list due to SOL dapp limitation

cc @jamesmudgett @Douglashdaniel
@mrose17
Copy link
Member

mrose17 commented Jun 16, 2023

Thank you!

@darkdh
Copy link
Member Author

darkdh commented Jun 16, 2023

This is more of a backend issue, we only propagate "selected" account to the permission system and then to UI for the user to decide. Instead, all SOL accounts should be passed and in SolanaProviderImpl::OnConnect setting the granted account as selected one if it is not selected yet.

@HEagle18 HEagle18 added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 23, 2023
@StephenHeaps StephenHeaps mentioned this issue Jun 23, 2023
Closed
@darkdh darkdh mentioned this issue Jul 8, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Jul 14, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.58.105 Chromium: 116.0.5845.114 (Official Build) beta (64-bit)
Revision 5a895596bcd7fcd930dab0714ea5cfa86c5aa0a7
OS Windows 11 Version 22H2 (Build 22621.2215)
  • Verified steps from brave/brave-core#19200
  • Verified solana connect prompt shows all available Solana accounts when connecting to a Dapp
31109.mp4

@LaurenWags LaurenWags mentioned this issue Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
feature/web3/wallet/core feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

Allow users to choose which SOL account to connect brave/brave-core
5 participants
@mrose17 @darkdh @HEagle18 @srirambv @brave-builds