Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix action color in dark mode #31141

Closed
Pavneet-Sing opened this issue Jun 19, 2023 · 1 comment · Fixed by brave/brave-core#18982
Closed

Fix action color in dark mode #31141

Pavneet-Sing opened this issue Jun 19, 2023 · 1 comment · Fixed by brave/brave-core#18982
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.58.x - Release

Comments

@Pavneet-Sing
Copy link

Actual result

Screenshot from 2023-06-19 17-21-38

Expected result

Screenshot from 2023-06-19 17-13-22

Additional information

Same for:

  • Add NFT action
@Pavneet-Sing Pavneet-Sing added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality front-end-change This task is a front end task and doesn't need any C++ changes labels Jun 19, 2023
@Pavneet-Sing Pavneet-Sing self-assigned this Jun 19, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Jun 21, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.55.x - Nightly milestone Jun 22, 2023
@srirambv
Copy link
Contributor

srirambv commented Sep 6, 2023

Verification passed on Oppo Reno 5 with Android 13 running 1.58.114 x64 Beta build

  • Verified steps from issue description
  • Verified Add custom asset button is now properly visible in dark theme
31141.mp4

This was referenced Sep 15, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

Add network selector in add asset dialog brave/brave-core
3 participants
@Pavneet-Sing @srirambv @brave-builds