Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Follow up to #29856] Top info panel (time, battery, notification indicators) is hidden when using "Share" on Brave Shields Menu #31206

Open
hffvld opened this issue Jun 21, 2023 · 0 comments
Assignees
Labels
bug feature/shields/panel Front-end design and functionality of the Shields panel. OS/Android Fixes related to Android browser functionality QA/Yes

Comments

@hffvld
Copy link
Contributor

hffvld commented Jun 21, 2023

Description

Follow-up to #29856

Steps to reproduce

  1. Launch Brave on a Samsung phone or tablet
  2. Go to any website > Brave Shields
  3. Tap Share > Observe

Actual result

The top info panel (time, battery, notification indicators, etc.) is hidden when using "Share" on the Brave Shields Menu. This only happens on Samsung devices in my case (Galaxy A32 5G [13] and Galaxy Tab S8 [13]), and is not reproducible on Pixel devices (Pixel 2 [8], Pixel 6 [13], Pixel 7 [14]). On a phone, the top panel is just getting hidden when tapping Share on the Brave Shields panel, but on a tablet whole Brave app is moving up when tapping Share.

Pixel 6. Share from Three-dot Menu Pixel 6. Share from Brave Shields Menu
1 2
Galaxy A32. Share from Three-dot Menu Galaxy A32. Share from Brave Shields Menu
1 2
Galaxy Tab S8. Share from Three-dot Menu Galaxy Tab S8. Share from Brave Shields Menu
1 2
timestamp_11-42-48_11-43-05.mp4

Expected result

Brave UI must not move up and down, as well as the top info panel (time, battery, notification indicators, etc.) must not be hidden when a user is using the Share button on the Brave Shields Menu.

Issue reproduces how often

Easily reproduced

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Galaxy A32 5G (phone) and Galaxy Tab S8 (tablet)
  • Android version: Android 13

Brave version

1.53.100
1.54.73

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@hffvld hffvld added OS/Android Fixes related to Android browser functionality bug QA/Yes feature/shields/panel Front-end design and functionality of the Shields panel. labels Jun 21, 2023
@deeppandya deeppandya self-assigned this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/shields/panel Front-end design and functionality of the Shields panel. OS/Android Fixes related to Android browser functionality QA/Yes
Projects
None yet
Development

No branches or pull requests

2 participants