Share button in Brave Shields does nothing

[SergeyZhukovsky]

It happens on a stable 1.50.x channel as well. It looks like it regressed for some time.

Edit: It looks it works on some devices. I tried on Pixel 6 Android 13 and it doesn't work.

[deeppandya]

it's known issue for android 13. could be related to runtime permissions

[kjozwiak]

@deeppandya @SergeyZhukovsky I couldn't reproduce the issue I saw re: the icon being greyed out but I can confirm that I can reproduce the same issue on Pixel 6 running Android 14. I can reproduce it without/with Notifications enabled.

Brave | 1.50.121 Chromium: 112.0.5615.138 (Official Build) (32-bit)
--- | ---
Revision | 2258f2fcaeb07bc95c992b7ca47f0b43ead9865c-refs/branch-heads/5615@{#1282}
OS | Android 13; Build/UPB1.230309.014

Even though the above mentions Android 13, it's Android 14 as they haven't updated the OS version yet. Appears as UpsideDownCake.

STR/Cases:

• launch 1.50.121 Chromium: 112.0.5615.138 and run through onboarding
• open any website and tap on the brave shields panel, tap on the Share icon and notice nothing happens

Reproduceable with All Brave notifications enabled and disabled. Seems to be working fine via Android 12. Tapping on the Share button initiates a request for permissions. I think @timchilds was right re: the above regressing with Android 13 permissions introduction. Example of Android 12 working:

Screen_Recording_20230420_003903_Brave.mp4

[hffvld]

Verified on Pixel 2 XL, Pixel 6, Pixel 7, Galaxy A32 5G and Galaxy Tab S8 using version(s):

Device/OS: 
- Pixel 2 XL [taimen-user 8.1.0 OPM2.171026.006.H1 release-keys]
- Pixel 6 [oriole-user 13 TQ2A.230505.002 release-keys]
- Pixel 7 [panther_beta-user 14 UPB2.230407.014 release-keys]
- Galaxy A32 5G [a32xsq-user 13 TP1A.220624.014 release-keys]
- Galaxy Tab S8 [gts8wifixx-user 13 TP1A.220624.014 release-keys]
Brave build: 1.53.81
Chromium: 114.0.5735.90 (Official Build) beta (64-bit)
Revision: 386bc09e8f4f2e025eddae123f36f6263096ae49-refs/branch-heads/5735@{#1052}

---

STEPS:

1. Install Brave > Launch Brave
2. Run through onboarding
3. Open any website > Tap on the Brave Shields panel
4. Tap on the Share icon > Verify

ACTUAL RESULTS:

• Verified that Brave Shields Share button is working fine on Android 8, Android 13 and Android 14

Android 8

timestamp_14-33-07_14-34-06.mp4

Android 13

timestamp_14-37-11_14-37-53.mp4

Android 14

timestamp_14-41-13_14-42-03.mp4

[kjozwiak]

The above requires 1.52.130 or higher for 1.52.x verification 👍 Removing the QA Pass labels as the above will need to be rechecked with 1.52.x.

[Uni-verse]

Verified on Samsung Galaxy S21 5G, Samsung Galaxy Tab S7, Pixel 5 using the following build(s):

Brave	1.52.130 Chromium: 114.0.5735.198 (Official Build) (32-bit) 
Revision	c3029382d11c5f499e4fc317353a43d411a5ce1c-refs/branch-heads/5735@{#1394}
OS	Android 13; Build/TP1A.220624.014; 33; REL

Brave	1.52.130 Chromium: 114.0.5735.198 (Official Build) (32-bit) 
Revision	c3029382d11c5f499e4fc317353a43d411a5ce1c-refs/branch-heads/5735@{#1394}
OS	Android 8.0.0; Build/OSR1.180418.026; 26; REL

• Verified tapping share button in Brave Shields opens up share window

GS21	Tab S7	Pixel 5 (Android 8)