Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token details menu option is partially shown when token graph is loading #31263

Closed
srirambv opened this issue Jun 23, 2023 · 1 comment · Fixed by brave/brave-core#19024
Closed
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Token details menu option is partially shown when token graph is loading

Steps to Reproduce

  1. Open any non-native token
  2. Click on token detail menu when graph is loading
  3. Token details menu option is partially shown when token graph is loading

Actual result:

image

Expected result:

Show on top of the graph loading layout

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.53.102 Chromium: 114.0.5735.133 (Official Build) (64-bit)
Revision fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS Windows 11 Version 22H2 (Build 22621.1848)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? nA

Miscellaneous Information:

cc: @Douglashdaniel

@Douglashdaniel Douglashdaniel self-assigned this Jun 23, 2023
@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label Jun 23, 2023
@brave-builds brave-builds added this to the 1.55.x - Nightly milestone Jun 24, 2023
@srirambv
Copy link
Contributor Author

srirambv commented Sep 1, 2023

Verification passed on

Brave 1.57.27 Chromium: 115.0.5790.1314 (Official Build) beta (64-bit)
Revision a4ad1fcdb550daf076384dbb280ae944274b3d35
OS Windows 11 Version 22H2 (Build 22621.2215)
  • Verified steps from brave/brave-core#19024
  • Verified reloading the page and quickly opening the Portfolio Settings Menu and scrolling down the page doesn't overlap on it
  • Verified The Line Chart loading state and other loading Skeletons don't overlap the Portfolio Settings Menu
31263.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants