Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Visible Assets Modal to V2 Design #31389

Closed
Douglashdaniel opened this issue Jun 29, 2023 · 1 comment · Fixed by brave/brave-core#19190
Closed

Update Visible Assets Modal to V2 Design #31389

Douglashdaniel opened this issue Jun 29, 2023 · 1 comment · Fixed by brave/brave-core#19190
Assignees
@Douglashdaniel
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.58.x - Release

Comments

@Douglashdaniel
Copy link

Description

We need to update the Edit Visible Assets modal to the V2 design.

Screenshot 26

Screenshot 27

Screenshot 28

Screenshot 29
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jun 29, 2023
@Douglashdaniel Douglashdaniel self-assigned this Jun 29, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Jul 7, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Jul 10, 2023
@srirambv
Copy link
Contributor

srirambv commented Sep 5, 2023

Verification passed on

Brave 1.58.114 Chromium: 116.0.5845.163 (Official Build) beta (64-bit)
Revision 21631edab5a70964c2f5817bfa4d06c32b4ab314
OS Linux
  • Verified steps from brave/brave-core#19190
  • Verified Visible Assets modal is as per new design
  • Verified My assets is selected by default
  • Verified hiding an asset and clicking Save changes work as expected
  • Verified Deleting an asset work as expected
  • Verified Add custom asset work as expected
31389.mp4

Verification passed on

Brave 1.58.114 Chromium: 116.0.5845.163 (Official Build) beta (64-bit)
Revision 21631edab5a70964c2f5817bfa4d06c32b4ab314
OS Windows 11 Version 22H2 (Build 22621.2215)
  • Verified steps from brave/brave-core#19190
  • Verified Visible Assets modal is as per new design
  • Verified My assets is selected by default
  • Verified hiding an asset and clicking Save changes work as expected
  • Verified Deleting an asset work as expected
  • Verified Add custom asset work as expected
31389.mp4

Verification passed on

Brave 1.58.114 Chromium: 116.0.5845.163 (Official Build) beta (arm64)
Revision 21631edab5a70964c2f5817bfa4d06c32b4ab314
OS macOS Version 13.4.1 (c) (Build 22F770820d)
  • Verified steps from brave/brave-core#19190
  • Verified Visible Assets modal is as per new design
  • Verified My assets is selected by default
  • Verified hiding an asset and clicking Save changes work as expected
  • Verified Deleting an asset work as expected
  • Verified Add custom asset work as expected
31389.mov

@LaurenWags LaurenWags mentioned this issue Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Visible Assets Modal V2 brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds