Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the flow for manually adding an NFT #31399

Closed
simoarpe opened this issue Jun 30, 2023 · 1 comment · Fixed by brave/brave-core#19404
Closed

Improve the flow for manually adding an NFT #31399

simoarpe opened this issue Jun 30, 2023 · 1 comment · Fixed by brave/brave-core#19404
Assignees
@simoarpe
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.58.x - Release

Comments

@simoarpe
Copy link

Description

Adding an NFT on Android is a cumbersome operation, as the button to reach the dialog is a bit hidden in the UI.

Android - iOS Comparison

Screen.Recording.2023-06-30.at.12.00.59.PM.mov

The main difference is that on Android the button is inside the screen to edit the visible assets.
We should go in favor of the iOS solution: the plus icon should be repositioned in the NFT screen.

⚠️ Note: because the current Android implementation is relying on a dialog and is sharing the logic with the screen behind, we should implement 27070 first.
@simoarpe simoarpe added priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Jun 30, 2023
@simoarpe simoarpe self-assigned this Jun 30, 2023
@simoarpe simoarpe mentioned this issue Jul 24, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Jul 25, 2023
@srirambv
Copy link
Contributor

srirambv commented Sep 8, 2023

Verification passed on the following devices running 1.58.117 x64 build

  • Verified steps from brave/brave-core#19404
  • Verified new adding a new NFT shows the new network selector
  • Verified manually added NFTs are listed in a grid
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
31399-ARM.mp4
31399-Tab.mp4

This was referenced Sep 15, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoarpe simoarpe

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

(Wallet) Improve flow to manually add NFTs brave/brave-core
3 participants
@simoarpe @srirambv @brave-builds