Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Solana at top in the list of networks #31506

Closed
Pavneet-Sing opened this issue Jul 7, 2023 · 1 comment · Fixed by brave/brave-core#19537
Closed

Show Solana at top in the list of networks #31506

Pavneet-Sing opened this issue Jul 7, 2023 · 1 comment · Fixed by brave/brave-core#19537
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.58.x - Release

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Jul 7, 2023 •
edited
Loading

Description

Show Solana at top in the list of networks (Everywhere) and sort alphabetically within the group.

Actual result

Screenshot from 2023-07-07 11-10-31

Expected result

Show Solana below All networks everywhere, above others and sort alphabetically within the group.

Additional information

Threads:
@Pavneet-Sing Pavneet-Sing added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. labels Jul 7, 2023
@Pavneet-Sing Pavneet-Sing self-assigned this Aug 1, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Aug 2, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Aug 3, 2023
@srirambv
Copy link
Contributor

srirambv commented Sep 6, 2023

Verification passed on Oppo Reno 5 with Android 13 running 1.58.114 x64 Beta build

  • Verified steps from issue description
  • Verified Solana is shown on top of network list
  • Encountered #32791
31506.mp4

@Pavneet-Sing Pavneet-Sing mentioned this issue Sep 6, 2023
Closed
This was referenced Sep 15, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

Show Solana network at top brave/brave-core
3 participants
@Pavneet-Sing @srirambv @brave-builds