Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockchainRegistry.getAllTokens sometimes doesn't return tokens #31669

Closed
josheleonard opened this issue Jul 17, 2023 · 1 comment · Fixed by brave/brave-core#19475
Closed
Assignees
Labels
bug feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include

Comments

@josheleonard
Copy link

josheleonard commented Jul 17, 2023

Description

Seems like calling this function early in the wallet page startup process can sometimes return empty results

Steps to Reproduce

  1. filter the deposit tokens list to Solana mainnet
  2. Close brave
  3. unlock wallet directly to deposit screen
  4. sometimes, the list only loads only SOL and eventually tokens from the user's list.

Actual result:

deposit.screen.tokens.bug.mp4

Expected result:

All assets should always be loaded (native asset, user tokens, 'known' tokens)

Reproduces how often:

Intermittent issue

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.58.100 Chromium: 116.0.5845.114 (Official Build) beta (64-bit)
Revision a8c0058265009a1858c4502b9ba413671fbb61e1
OS Windows 11 Version 22H2 (Build 22621.2215)
  • Verified steps from brave/brave-core#19475
  • Verified all tokens from Solana Mainnet are shown when browser is restarted directly into deposit screen
31669.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants