Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf: Virtualize the tokens list in the buy & deposit screens #31675

Closed
josheleonard opened this issue Jul 17, 2023 · 1 comment · Fixed by brave/brave-core#19306
Closed

Perf: Virtualize the tokens list in the buy & deposit screens #31675

josheleonard opened this issue Jul 17, 2023 · 1 comment · Fixed by brave/brave-core#19306
Assignees
@josheleonard
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop perf QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.58.x - Release

Comments

@josheleonard
Copy link
Collaborator

josheleonard commented Jul 17, 2023 •
edited

Description

Use a virtualized list to prevent rendering too many below-the-fold list items.

Steps to Reproduce

  1. Open the deposit screen
  2. select the all networks option from the filter

Actual result:

The page loads the entire list all at once

Expected result:

The tokens list should only render the list items that are visible

Reproduces how often:

Easy

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@josheleonard josheleonard self-assigned this Jul 17, 2023
@josheleonard josheleonard mentioned this issue Jul 17, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Jul 17, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.58.100 Chromium: 116.0.5845.114 (Official Build) beta (64-bit)
Revision a8c0058265009a1858c4502b9ba413671fbb61e1
OS Windows 11 Version 22H2 (Build 22621.2215)

@LaurenWags LaurenWags mentioned this issue Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop perf QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

fix: add virtualized list to buy & deposit screens brave/brave-core
3 participants
@srirambv @josheleonard @brave-builds