Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 115.0.5790.90 to Chromium 115.0.5790.98 #31682

Closed
emerick opened this issue Jul 17, 2023 · 7 comments · Fixed by brave/brave-core#19316
Closed

Upgrade from Chromium 115.0.5790.90 to Chromium 115.0.5790.98 #31682

emerick opened this issue Jul 17, 2023 · 7 comments · Fixed by brave/brave-core#19316
Assignees
@emerick @mkarolin
Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-macOS-arm64 QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.56.x - Release

Comments

@emerick
Copy link
Contributor

emerick commented Jul 17, 2023

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/115.0.5790.90..115.0.5790.98?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@emerick emerick added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Desktop labels Jul 17, 2023
@emerick emerick added this to the 1.56.x - Release milestone Jul 17, 2023
This was referenced Jul 17, 2023
Merged
Merged
Merged
@kjozwiak kjozwiak mentioned this issue Jul 17, 2023
Closed
@kjozwiak
Copy link
Member

Closing as brave/brave-core#19314 was merged into 1.56.x. The above will require 1.56.8 or higher for 1.56.x verification 👍

@GeetaSarvadnya
Copy link
Collaborator

Verification PASSED on

Brave | 1.56.8 Chromium: 115.0.5790.98 (Official Build) (64-bit)
-- | --
Revision | 4eacc220b55f07c57d5a1f4b7e0e63a6f7e420a1-refs/branch-heads/5790_90@{#4}
OS | Windows 10 Version 22H2 (Build 19045.3208)

image

@LaurenWags LaurenWags mentioned this issue Jul 18, 2023
Closed
@LaurenWags
Copy link
Member

Verified with

Brave | 1.56.8 Chromium: 115.0.5790.98 (Official Build) (x86_64)
-- | --
Revision | 4eacc220b55f07c57d5a1f4b7e0e63a6f7e420a1-refs/branch-heads/5790_90@{#4}
OS | macOS Version 13.4.1 (a) (Build 22F770820b)
Intel

@LaurenWags
Copy link
Member

Verified with

Brave	1.56.8 Chromium: 115.0.5790.98 (Official Build) (64-bit) 
Revision	4eacc220b55f07c57d5a1f4b7e0e63a6f7e420a1-refs/branch-heads/5790_90@{#4}
OS	Linux
Linux

@Uni-verse
Copy link
Collaborator

Verified on Samsung Galaxy S21 using version:

Brave	1.56.8 Chromium: 115.0.5790.98 (Official Build) (64-bit) 
Revision	4eacc220b55f07c57d5a1f4b7e0e63a6f7e420a1-refs/branch-heads/5790_90@{#4}
OS	Android 13; Build/TP1A.220624.014; 33; REL
Example Example
screenshot-1689692480630 screenshot-1689692515846

@LaurenWags
Copy link
Member

Verified with

Brave	1.56.8 Chromium: 115.0.5790.98 (Official Build) (arm64) 
Revision	4eacc220b55f07c57d5a1f4b7e0e63a6f7e420a1-refs/branch-heads/5790_90@{#4}
OS	macOS Version 13.4.1 (c) (Build 22F770820d)

M1

@Uni-verse
Copy link
Collaborator

Verified on Samsung Galaxy Tab S7 using version

Brave	1.56.8 Chromium: 115.0.5790.98 (Official Build) (64-bit) 
Revision	4eacc220b55f07c57d5a1f4b7e0e63a6f7e420a1-refs/branch-heads/5790_90@{#4}
OS	Android 13; Build/TP1A.220624.014; 33; REL
Example Example
Screenshot 2023-07-18 at 11 12 59 AM Screenshot 2023-07-18 at 11 13 26 AM

@kjozwiak kjozwiak mentioned this issue Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

@mkarolin mkarolin

Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-macOS-arm64 QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.56.x - Release
Development

Successfully merging a pull request may close this issue.

Upgrade from Chromium 115.0.5790.90 to Chromium 115.0.5790.98 brave/brave-core
6 participants
@kjozwiak @emerick @Uni-verse @LaurenWags @GeetaSarvadnya @mkarolin