Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet New Connection Panel closes / reopens on Magic Eden #31853

Closed
StephenHeaps opened this issue Jul 25, 2023 · 1 comment · Fixed by brave/brave-core#19444
Closed

Wallet New Connection Panel closes / reopens on Magic Eden #31853

StephenHeaps opened this issue Jul 25, 2023 · 1 comment · Fixed by brave/brave-core#19444

Comments

@StephenHeaps
Copy link
Collaborator

Description

When attempting to connect to connect to Magic Eden for the first time, the wallet panel opens and closes repeatedly. Magic Eden appears to continually send new connection requests which get rejecting automatically due to the pending request still being open (rejections visible in console).

Steps to Reproduce

  1. Clear browsing data for Magic Eden, bug appears to only work when first visiting.
  2. Visit https://magiceden.io/ and click Connect Wallet, Select Brave Wallet
  3. Observe panel opens and closes repeatedly. If you check the console, you can see more requests being send and rejected due to pending request.
  4. Quit Brave
  5. Re-launch Brave
  6. You should be able to connect as expected now. Clear browsing data & Solana permissions to reproduce again.

Actual result:

magic.eden.connect.mov

Expected result:

Panel does not close until user closes it via cancel / approve / clicking elsewhere.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version 1.58.46 Chromium: 115.0.5790.136 (Official Build) nightly (arm64)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.58.100 Chromium: 116.0.5845.114 (Official Build) beta (64-bit)
Revision a8c0058265009a1858c4502b9ba413671fbb61e1
OS Windows 11 Version 22H2 (Build 22621.2215)
  • Verified steps from issue description
  • Verified wallet connection panel doesn't close when loading https://magiceden.io
  • Verified able to connect and sign without issues
31853.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment