Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical tab bar issues #31925

Closed
wknapik opened this issue Jul 27, 2023 · 2 comments · Fixed by brave/brave-core#18656
Closed

Vertical tab bar issues #31925

wknapik opened this issue Jul 27, 2023 · 2 comments · Fixed by brave/brave-core#18656

Comments

@wknapik
Copy link
Contributor

wknapik commented Jul 27, 2023

Description

Once the vertical tab bar is full (has as many tabs as can be shown without scrolling), ctrl+tabbing from the last tab switches to the first one, but the tabs are bottom-aligned and only the active one and those before it are shown.

image | image | image

Steps to Reproduce

  1. Open enough tabs to fill the tab bar
  2. Go to the last tab
  3. Ctrl+tab

Actual result:

Tabs bottom-aligned and ones after the active one not visible

Expected result:

Tabs top-aligned and ones after the active one visible

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

1.56.11 Chromium: 115.0.5790.102 (Official Build) (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? ?
  • Can you reproduce this issue with the nightly channel? ?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? ?

Miscellaneous Information:

Slack thread

@kjozwiak
Copy link
Member

kjozwiak commented Aug 1, 2023

Closing as the above was fixed via brave/brave-core#18656. The above requires 1.56.18 or higher for 1.56.x verification 👍

@kjozwiak kjozwiak closed this as completed Aug 1, 2023
@GeetaSarvadnya
Copy link
Collaborator

Verification PASSED on

Brave	1.56.18 Chromium: 115.0.5790.138 (Official Build) (64-bit) 
Revision	0567db0e7dcdfee5c109c167119ac2a92b9b3e1a-refs/branch-heads/5790_85@{#9}
OS	Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants