Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Coinbase on-ramp(frontend) #32083

Closed
muliswilliam opened this issue Aug 4, 2023 · 1 comment · Fixed by brave/brave-core#19573
Closed

Add Coinbase on-ramp(frontend) #32083

muliswilliam opened this issue Aug 4, 2023 · 1 comment · Fixed by brave/brave-core#19573
Assignees
@muliswilliam
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.58.x - Release

Comments

@muliswilliam
Copy link
Collaborator

muliswilliam commented Aug 4, 2023 •
edited

Figma link

Test Plan:

  • Go to brave://wallet
  • Click on Buy
  • On the buy page, select a token e.g Ethereum
  • Click on Continue
  • On the onramp page, Coinbase Pay should listed as an option
  • Select coinbase pay
  • A new tab opens and loads coinbase pay widget
@muliswilliam muliswilliam self-assigned this Aug 4, 2023
@muliswilliam muliswilliam mentioned this issue Aug 4, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Aug 8, 2023
@StephenHeaps StephenHeaps mentioned this issue Aug 15, 2023
Closed
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.58.100 Chromium: 116.0.5845.114 (Official Build) beta (64-bit)
Revision a8c0058265009a1858c4502b9ba413671fbb61e1
OS Windows 11 Version 22H2 (Build 22621.2215)
  • Verified steps from issue description
  • Verified Coinbase is shown as an On-ramp provider on Buy screen
  • Verified selecting Coinbase opens Coinbase pay widget is loaded in a new tab
32083.mp4

@rebron rebron changed the title Add coinbase on-ramp(frontend) Add Coinbase on-ramp(frontend) Aug 31, 2023
@LaurenWags LaurenWags mentioned this issue Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet) Add Coinbase Pay on-ramp brave/brave-core
3 participants
@srirambv @brave-builds @muliswilliam