Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for swaps on Base #32235

Closed
onyb opened this issue Aug 14, 2023 · 2 comments · Fixed by brave/brave-core#19672
Closed

Add support for swaps on Base #32235

onyb opened this issue Aug 14, 2023 · 2 comments · Fixed by brave/brave-core#19672
Assignees
@onyb
Labels
feature/web3/wallet/core feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass-Linux QA/Yes release-notes/include
Milestone
1.57.x - Release #4

Comments

@onyb
Copy link
Member

onyb commented Aug 14, 2023

0x recently added support for Base.

Test plan

Add Base as a custom network. Head over to "Swap" tab, and you should be able to select Base and generate swap quotes.
@onyb onyb added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop feature/web3/wallet/swap labels Aug 14, 2023
@onyb onyb self-assigned this Aug 14, 2023
@onyb onyb mentioned this issue Aug 14, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.59.x - Nightly milestone Aug 15, 2023
This was referenced Aug 15, 2023
Merged
Merged
@kjozwiak
Copy link
Member

The above requires 1.57.52 or higher for 1.57.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.57.52 Chromium: 116.0.5845.96 (Official Build) (64-bit)
Revision 1f876d1266f048189d3cc887cfa5208508ac8194
OS Linux
  • Verified steps from issue description
  • Verified Base added as a a network shows up under Swaps
  • Verified able to select Base as Swap network and able to generate swap quotes for tokens
32235.mp4

@LaurenWags LaurenWags mentioned this issue Aug 23, 2023
Closed
@kjozwiak kjozwiak mentioned this issue Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet/core feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass-Linux QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.57.x - Release #4
Development

Successfully merging a pull request may close this issue.

feat(wallet): add support for swaps on Base brave/brave-core
4 participants
@kjozwiak @onyb @srirambv @brave-builds