Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android :: Update "lock" icon to "tune" icon in address bar #32380

Closed
anthonypkeane opened this issue Aug 18, 2023 · 3 comments
Closed

Android :: Update "lock" icon to "tune" icon in address bar #32380

anthonypkeane opened this issue Aug 18, 2023 · 3 comments
Assignees
Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include

Comments

@anthonypkeane
Copy link

Description

Needed for C117

Details: #31642
Figma: https://www.figma.com/file/H11ZOl6JMYbCTW4ZJXqR5V/%F0%9F%A6%81-Browser?type=design&node-id=2050%3A19224&mode=design&t=eXPxIDq3WXHZFVxo-1

@anthonypkeane anthonypkeane added the OS/Android Fixes related to Android browser functionality label Aug 18, 2023
samartnik added a commit to samartnik/brave-core that referenced this issue Aug 23, 2023
Updated omnibox icons as part of this issue `Android :: Update "lock" icon to "tune" icon in address bar` brave/brave-browser#32380

Chromium change:
brave/chromium@13c5957

Add Chrome2023 refresh Secure icon on Android
The Chrome2023 refresh changes are specific to desktop, but the lock
icon replacement is meant to launch on Android too. This adds it
reusing the kUpdatedConnectionSecurityIndicators flag, which previously
controlled the chevron experiment. This CL also removes the chevron
icon.

Bug: 1468591
samartnik added a commit to brave/brave-core that referenced this issue Aug 23, 2023
Updated omnibox icons as part of this issue `Android :: Update "lock" icon to "tune" icon in address bar` brave/brave-browser#32380

Chromium change:
brave/chromium@13c5957

Add Chrome2023 refresh Secure icon on Android
The Chrome2023 refresh changes are specific to desktop, but the lock
icon replacement is meant to launch on Android too. This adds it
reusing the kUpdatedConnectionSecurityIndicators flag, which previously
controlled the chevron experiment. This CL also removes the chevron
icon.

Bug: 1468591
cdesouza-chromium pushed a commit to brave/brave-core that referenced this issue Aug 23, 2023
Updated omnibox icons as part of this issue `Android :: Update "lock" icon to "tune" icon in address bar` brave/brave-browser#32380

Chromium change:
brave/chromium@13c5957

Add Chrome2023 refresh Secure icon on Android
The Chrome2023 refresh changes are specific to desktop, but the lock
icon replacement is meant to launch on Android too. This adds it
reusing the kUpdatedConnectionSecurityIndicators flag, which previously
controlled the chevron experiment. This CL also removes the chevron
icon.

Bug: 1468591
cdesouza-chromium pushed a commit to brave/brave-core that referenced this issue Aug 24, 2023
Updated omnibox icons as part of this issue `Android :: Update "lock" icon to "tune" icon in address bar` brave/brave-browser#32380

Chromium change:
brave/chromium@13c5957

Add Chrome2023 refresh Secure icon on Android
The Chrome2023 refresh changes are specific to desktop, but the lock
icon replacement is meant to launch on Android too. This adds it
reusing the kUpdatedConnectionSecurityIndicators flag, which previously
controlled the chevron experiment. This CL also removes the chevron
icon.

Bug: 1468591
@samartnik
Copy link
Contributor

This will be fixed in the context of rebasing to C177 #31768

@samartnik
Copy link
Contributor

Screenshot_20230824-162256

@samartnik samartnik added this to the 1.58.x - Beta milestone Aug 24, 2023
mkarolin pushed a commit to brave/brave-core that referenced this issue Aug 25, 2023
Updated omnibox icons as part of this issue `Android :: Update "lock" icon to "tune" icon in address bar` brave/brave-browser#32380

Chromium change:
brave/chromium@13c5957

Add Chrome2023 refresh Secure icon on Android
The Chrome2023 refresh changes are specific to desktop, but the lock
icon replacement is meant to launch on Android too. This adds it
reusing the kUpdatedConnectionSecurityIndicators flag, which previously
controlled the chevron experiment. This CL also removes the chevron
icon.

Bug: 1468591
cdesouza-chromium pushed a commit to brave/brave-core that referenced this issue Aug 25, 2023
Updated omnibox icons as part of this issue `Android :: Update "lock" icon to "tune" icon in address bar` brave/brave-browser#32380

Chromium change:
brave/chromium@13c5957

Add Chrome2023 refresh Secure icon on Android
The Chrome2023 refresh changes are specific to desktop, but the lock
icon replacement is meant to launch on Android too. This adds it
reusing the kUpdatedConnectionSecurityIndicators flag, which previously
controlled the chevron experiment. This CL also removes the chevron
icon.

Bug: 1468591
cdesouza-chromium pushed a commit to brave/brave-core that referenced this issue Aug 26, 2023
Updated omnibox icons as part of this issue `Android :: Update "lock" icon to "tune" icon in address bar` brave/brave-browser#32380

Chromium change:
brave/chromium@13c5957

Add Chrome2023 refresh Secure icon on Android
The Chrome2023 refresh changes are specific to desktop, but the lock
icon replacement is meant to launch on Android too. This adds it
reusing the kUpdatedConnectionSecurityIndicators flag, which previously
controlled the chevron experiment. This CL also removes the chevron
icon.

Bug: 1468591
mkarolin pushed a commit to brave/brave-core that referenced this issue Aug 27, 2023
Updated omnibox icons as part of this issue `Android :: Update "lock" icon to "tune" icon in address bar` brave/brave-browser#32380

Chromium change:
brave/chromium@13c5957

Add Chrome2023 refresh Secure icon on Android
The Chrome2023 refresh changes are specific to desktop, but the lock
icon replacement is meant to launch on Android too. This adds it
reusing the kUpdatedConnectionSecurityIndicators flag, which previously
controlled the chevron experiment. This CL also removes the chevron
icon.

Bug: 1468591
cdesouza-chromium pushed a commit to brave/brave-core that referenced this issue Aug 28, 2023
Updated omnibox icons as part of this issue `Android :: Update "lock" icon to "tune" icon in address bar` brave/brave-browser#32380

Chromium change:
brave/chromium@13c5957

Add Chrome2023 refresh Secure icon on Android
The Chrome2023 refresh changes are specific to desktop, but the lock
icon replacement is meant to launch on Android too. This adds it
reusing the kUpdatedConnectionSecurityIndicators flag, which previously
controlled the chevron experiment. This CL also removes the chevron
icon.

Bug: 1468591
mkarolin pushed a commit to brave/brave-core that referenced this issue Aug 31, 2023
Updated omnibox icons as part of this issue `Android :: Update "lock" icon to "tune" icon in address bar` brave/brave-browser#32380

Chromium change:
brave/chromium@13c5957

Add Chrome2023 refresh Secure icon on Android
The Chrome2023 refresh changes are specific to desktop, but the lock
icon replacement is meant to launch on Android too. This adds it
reusing the kUpdatedConnectionSecurityIndicators flag, which previously
controlled the chevron experiment. This CL also removes the chevron
icon.

Bug: 1468591
cdesouza-chromium pushed a commit to brave/brave-core that referenced this issue Sep 1, 2023
Updated omnibox icons as part of this issue `Android :: Update "lock" icon to "tune" icon in address bar` brave/brave-browser#32380

Chromium change:
brave/chromium@13c5957

Add Chrome2023 refresh Secure icon on Android
The Chrome2023 refresh changes are specific to desktop, but the lock
icon replacement is meant to launch on Android too. This adds it
reusing the kUpdatedConnectionSecurityIndicators flag, which previously
controlled the chevron experiment. This CL also removes the chevron
icon.

Bug: 1468591
mkarolin pushed a commit to brave/brave-core that referenced this issue Sep 1, 2023
Updated omnibox icons as part of this issue `Android :: Update "lock" icon to "tune" icon in address bar` brave/brave-browser#32380

Chromium change:
brave/chromium@13c5957

Add Chrome2023 refresh Secure icon on Android
The Chrome2023 refresh changes are specific to desktop, but the lock
icon replacement is meant to launch on Android too. This adds it
reusing the kUpdatedConnectionSecurityIndicators flag, which previously
controlled the chevron experiment. This CL also removes the chevron
icon.

Bug: 1468591
mkarolin pushed a commit to brave/brave-core that referenced this issue Sep 2, 2023
Updated omnibox icons as part of this issue `Android :: Update "lock" icon to "tune" icon in address bar` brave/brave-browser#32380

Chromium change:
brave/chromium@13c5957

Add Chrome2023 refresh Secure icon on Android
The Chrome2023 refresh changes are specific to desktop, but the lock
icon replacement is meant to launch on Android too. This adds it
reusing the kUpdatedConnectionSecurityIndicators flag, which previously
controlled the chevron experiment. This CL also removes the chevron
icon.

Bug: 1468591
cdesouza-chromium pushed a commit to brave/brave-core that referenced this issue Sep 4, 2023
Updated omnibox icons as part of this issue `Android :: Update "lock" icon to "tune" icon in address bar` brave/brave-browser#32380

Chromium change:
brave/chromium@13c5957

Add Chrome2023 refresh Secure icon on Android
The Chrome2023 refresh changes are specific to desktop, but the lock
icon replacement is meant to launch on Android too. This adds it
reusing the kUpdatedConnectionSecurityIndicators flag, which previously
controlled the chevron experiment. This CL also removes the chevron
icon.

Bug: 1468591
cdesouza-chromium pushed a commit to brave/brave-core that referenced this issue Sep 5, 2023
Updated omnibox icons as part of this issue `Android :: Update "lock" icon to "tune" icon in address bar` brave/brave-browser#32380

Chromium change:
brave/chromium@13c5957

Add Chrome2023 refresh Secure icon on Android
The Chrome2023 refresh changes are specific to desktop, but the lock
icon replacement is meant to launch on Android too. This adds it
reusing the kUpdatedConnectionSecurityIndicators flag, which previously
controlled the chevron experiment. This CL also removes the chevron
icon.

Bug: 1468591
cdesouza-chromium pushed a commit to brave/brave-core that referenced this issue Sep 6, 2023
Updated omnibox icons as part of this issue `Android :: Update "lock" icon to "tune" icon in address bar` brave/brave-browser#32380

Chromium change:
brave/chromium@13c5957

Add Chrome2023 refresh Secure icon on Android
The Chrome2023 refresh changes are specific to desktop, but the lock
icon replacement is meant to launch on Android too. This adds it
reusing the kUpdatedConnectionSecurityIndicators flag, which previously
controlled the chevron experiment. This CL also removes the chevron
icon.

Bug: 1468591
@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 8, 2023
@Uni-verse
Copy link
Contributor

Uni-verse commented Sep 8, 2023

Verified on Samsung GS 21 using the following version(s):

Brave	1.58.117 Chromium: 116.0.5845.180 (Official Build) (64-bit) 
Revision	99255ad6abf2fa399c063683c051f973e1f5c0af
OS	Android 13; Build/TP1A.220624.014; 33; REL

New Profile

  • Ensured lock icon is updated to tune icon in address bar.
  • Ensured loading insecure page will display warning icon in address bar.
  • Ensured options in new icon is accessible / functional.
Example Example Example Example
Screenshot 2023-09-08 at 4 27 14 PM Screenshot 2023-09-08 at 4 26 36 PM Screenshot 2023-09-08 at 4 26 45 PM Screenshot 2023-09-08 at 4 26 52 PM

Existing Profile

  • Ensured icon in address bar is updated in bottom bar and top bottom mode.
  • Ensured history is displayed in the tune icon post upgrade.
Example Example Example
Screenshot 2023-09-11 at 1 52 48 PM Screenshot 2023-09-11 at 2 07 28 PM Screenshot 2023-09-11 at 2 04 47 PM

@Uni-verse Uni-verse added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Development

No branches or pull requests

4 participants