Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Submit shields report with origin + path #32640

Closed
deeppandya opened this issue Aug 31, 2023 · 2 comments · Fixed by brave/brave-core#19958
Closed

[Android] Submit shields report with origin + path #32640

deeppandya opened this issue Aug 31, 2023 · 2 comments · Fixed by brave/brave-core#19958
Assignees
Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include webcompat/reports Websites from webcompat reporter

Comments

@deeppandya
Copy link

deeppandya commented Aug 31, 2023

Description

This is to submit shields report with url instead of domain

Steps to reproduce

  1. open shields panel
  2. Have Brave shields DOWN
  3. Tap on Report a broken site
  4. Submit the report

@Uni-verse @hffvld can use brave/brave-core#19958 (comment) as a template as well when running through verifications.

Actual result

Currently we submit domain for the broken site

Expected result

We should submit full url for the broken site

Issue reproduces how often

Easily

Version/Channel Information:

All

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@deeppandya deeppandya added QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels Aug 31, 2023
@deeppandya deeppandya self-assigned this Aug 31, 2023
@deeppandya deeppandya changed the title [Android] Submit shields report with url [Android] Submit shields report with origin + path Oct 19, 2023
@brave-builds brave-builds added this to the 1.61.x - Nightly milestone Oct 20, 2023
@kjozwiak kjozwiak added reports webcompat/reports Websites from webcompat reporter labels Oct 25, 2023
@kjozwiak
Copy link
Member

The above requires 1.59.124 or higher for 1.59.x verification 👍

@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.59.124 Chromium: 118.0.5993.117 (Official Build) (64-bit)
--- | ---
Revision | 63d57e32ce0ff0a1e380461bc394351e97d1416a
OS | Android 14; Build/U1B2.230922.010; 34; REL

Using the STR/information from brave/brave-core#19958 (comment), went through the following:

Quick Note: Still having the network/DB issues re: 500 internal error as mentioned via brave/brave-core#19958 (comment) and discussed via https://bravesoftware.slack.com/archives/C03MMJ4CHEZ/p1698199867211709.

Example Example
Screenshot_20231025-113132 Screenshot 2023-10-25 at 11 36 35 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include webcompat/reports Websites from webcompat reporter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants