Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Open in new tab" is not working as expected and instead is opening a new tab in group #32853

Closed
hffvld opened this issue Sep 7, 2023 · 4 comments · Fixed by brave/brave-core#20118

Comments

@hffvld
Copy link
Contributor

hffvld commented Sep 7, 2023

Description

Open in new tab is not working as expected and instead working the same way as Open in new tab in group.

Steps to reproduce

  1. Launch Brave
  2. Open NTP > Top sites
  3. Tap and hold on any of them > In the context menu tap Open in new tab
  4. Tap Switch tabs button > Observe
  5. Now close all tabs > Open https://wikipedia.org
  6. Tap and hold on any link > Open in new tab
  7. Tap Switch tabs button > Observe

Actual result

Open in new tab is not working as expected and instead working the same way as Open in new tab in group. The issue is not happening in the previous Brave build with C116, because Open in new tab in the context menu is not available there.

1 2 3
1 2 3
timestamp_11-32-33_11-33-05.mp4

Expected result

Open in new tab must open a link in the new tab, but not in the group tab.

Issue reproduces how often

Easily reproduced

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? No
  • Can you reproduce this issue with the current Play Store Beta version? No
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Galaxy Tab S8 (Tablet)
  • Android version: Android 13

Brave version

Brave build: 1.60.3
Chromium: 117.0.5938.35 (Official Build) canary (64-bit)
Revision: 6f3491e

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@kjozwiak
Copy link
Member

The above requires 1.58.122 or higher for 1.58.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 12, 2023
@LaurenWags
Copy link
Member

@samartnik should this be release-notes/include or release-notes/exclude?

@samartnik
Copy link
Contributor

should this release-notes/include, i updated it

@hffvld
Copy link
Contributor Author

hffvld commented Sep 13, 2023

Verified on Galaxy Tab S8 using version(s):

Device/OS: Galaxy Tab S8 [gts8wifixx-user 13 TP1A.220624.014 release-keys]
Brave build: 1.58.122
Chromium: 117.0.5938.62 (Official Build) (64-bit)
Revision: 623437a8c792953b7bc4574f2d9ccdfd59e0ca67

STEPS:

  1. Launch Brave
  2. Three-dot menu > Settings > Appearance > Confirm that Only open links in current tab group is ON
  3. NTP > On Top sites tap and hold on any favicon > Tap Open in new tab in group
  4. Tap Switch tab button > Verify
  5. NTP > On Top sites tap and hold on any favicon > Tap Open in new tab
  6. Tap Switch tab button > Verify
  7. NTP > Open https://foxnews.com or any other supported website > Open any article
  8. Tap on a link in the article > Tap Switch tab button > Verify
  9. Now go to Settings and disable Only open links in current tab group
  10. Repeat Steps 3 - 8

ACTUAL RESULTS:

  • Verified that a new tab is opened in a group when using Open in new tab in group option in the context menu when Only open links in current tab group is ON or OFF
  • Verified that a new tab is opened as a separate tab and not in a group when using Open in new tab option in the context menu when Only open links in current tab group is ON or OFF
  • Verified that links on supported websites are opened in a group when Only open links in current tab group is ON
  • Verified that links on supported websites are opened in a separate tab when Only open links in current tab group is OFF

Only open links in current tab group is ON

timestamp_10-24-19_10-25-24_1.mov

Only open links in current tab group is OFF

timestamp_10-27-57_10-29-10_1.mov

@hffvld hffvld added QA Pass - Android Tab and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants