Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sync] Enable History sync data type #32876

Closed
AlexeyBarabash opened this issue Sep 8, 2023 · 3 comments · Fixed by brave/brave-core#20329
Closed

[Sync] Enable History sync data type #32876

AlexeyBarabash opened this issue Sep 8, 2023 · 3 comments · Fixed by brave/brave-core#20329

Comments

@AlexeyBarabash
Copy link
Contributor

Since CR117 Chromium uses history datatype instead of typed urls.
To fix #32857 regression, was done brave/brave-core#20071. But we need a proper PR which in fact uses history datatype.

@kjozwiak
Copy link
Member

The above requires 1.60.105 or higher for 1.60.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 31, 2023
@hffvld
Copy link
Contributor

hffvld commented Oct 31, 2023

Verified on Pixel 2 XL, Pixel 6 and Pixel 7 using version(s):

Device/OS:
- Pixel 2 XL [taimen-user  8.1.0 OPM2.171026.006.H1 release-keys]
- Pixel 6 [oriole-user 13 TQ3A.230901.001 release-keys]
- Pixel 7 [panther_beta-user 14 U1B2.230922.010 release-keys]
Brave build: 1.60.108
Chromium: 119.0.6045.59 (Official Build) (64-bit) 
Revision: 3a68c09d9a18cd981fc6bdf3d9e4bda65f57024f

STEPS:

  1. Followed the steps from Enable History datatype for Sync brave-core#20329 (comment)

ACTUAL RESULTS:

  • Verified that history is datatype synced now.

1 2
1 2
1 2
1 2
1 2
1

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 31, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 31, 2023

Verification PASSED on

Brave | 1.60.108 Chromium: 119.0.6045.59 (Official Build) (64-bit)
-- | --
Revision | 3a68c09d9a18cd981fc6bdf3d9e4bda65f57024f
OS | Windows 10 Version 22H2 (Build 19045.3570)

1. Browse/manual remove history entries _PASSED

Device A Device B Device C
image image (1) image

Initial Bookmarks on Device A and Device B

Device A Device B
image (2) image (3)

Final result

  • Confirmed that removed history from Device A and Device B is removed from both devices A, B history list in a sync chain
  • Confirmed that the removed history from Device A and Device B is removed from the Device C is a sync chain
Device A Device B Device C
image image (1) image (2)

II. Time-based history cleanup

image (3)

  • Confirmed that the deleted history via brave://settings/clearBrowserData is removed from all the devices in a sync chain
Device A Device B Device C
image image image

III. Ensure url from chrome.history.deleteUrl is not leaked.

  • Confirmed that the "url_directive": { is not found in the terminal
Example Example
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Sync - All platforms
  
Completed
Development

Successfully merging a pull request may close this issue.

6 participants