Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init PrivacyHubMetrics in a wrong place #32944

Closed
SergeyZhukovsky opened this issue Sep 12, 2023 · 1 comment · Fixed by brave/brave-core#20132
Closed

Init PrivacyHubMetrics in a wrong place #32944

SergeyZhukovsky opened this issue Sep 12, 2023 · 1 comment · Fixed by brave/brave-core#20132
Assignees
@SergeyZhukovsky
Labels
OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/include
Milestone
1.60.x - Release

Comments

@SergeyZhukovsky
Copy link
Member

I found that crash in GPS on a stable 1.57.62:

Exception java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.Class java.lang.Object.getClass()' on a null object reference
  at org.chromium.chrome.browser.brave_stats.BraveStatsUtil.showBraveStats (BraveStatsUtil.java:111)
  at org.chromium.chrome.browser.app.BraveActivity.checkForBraveStats (BraveActivity.java:1421)
  at org.chromium.chrome.browser.app.BraveActivity.checkForNotificationData (BraveActivity.java:1386)
  at org.chromium.chrome.browser.app.BraveActivity.checkAndshowNotificationWarningDialog (BraveActivity.java:1374)
  at org.chromium.chrome.browser.app.BraveActivity.finishNativeInitialization (BraveActivity.java:946)
  at org.chromium.chrome.browser.ChromeTabbedActivity.finishNativeInitialization (ChromeTabbedActivity.java:992)
  at org.chromium.base.CallbackController$CancelableRunnable.run (CallbackController.java:130)
  at android.os.MessageQueue.nativePollOnce
  at android.os.MessageQueue.next (MessageQueue.java:341)
  at android.os.Looper.loopOnce (Looper.java:169)
  at android.os.Looper.loop (Looper.java:300)
  at android.app.ActivityThread.main (ActivityThread.java:8410)
  at java.lang.reflect.Method.invoke
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:559)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:954)
@SergeyZhukovsky SergeyZhukovsky added crash priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include OS/Android Fixes related to Android browser functionality labels Sep 12, 2023
@SergeyZhukovsky SergeyZhukovsky self-assigned this Sep 12, 2023
@SergeyZhukovsky
Copy link
Member Author

SergeyZhukovsky commented Sep 12, 2023 •
edited

It looks like the crash itself has been fixed brave/brave-core#19793, but we init PrivacyHubMetrics in a wrong place(in wallet services init)

@SergeyZhukovsky SergeyZhukovsky mentioned this issue Sep 12, 2023
Merged
25 tasks
@SergeyZhukovsky SergeyZhukovsky added priority/P3 The next thing for us to work on. It'll ride the trains. and removed crash priority/P2 A bad problem. We might uplift this to the next planned release. labels Sep 13, 2023
@SergeyZhukovsky SergeyZhukovsky changed the title Crash on PrivacyHubMetric Init PrivacyHubMetrics in a wrong place Sep 13, 2023
@brave-builds brave-builds added this to the 1.60.x - Nightly milestone Sep 13, 2023
@kjozwiak kjozwiak mentioned this issue Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergeyZhukovsky SergeyZhukovsky

Labels
OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/include
Projects
None yet
Milestone
1.60.x - Release
Development

Successfully merging a pull request may close this issue.

Inits PrivacyHubMetrics in a dedicated place on Android brave/brave-core
2 participants
@SergeyZhukovsky @brave-builds