Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTT (aka SI) should show every 3 NTP view instead of every 4 #33228

Closed
petemill opened this issue Sep 25, 2023 · 2 comments · Fixed by brave/brave-core#19823
Closed

NTT (aka SI) should show every 3 NTP view instead of every 4 #33228

petemill opened this issue Sep 25, 2023 · 2 comments · Fixed by brave/brave-core#19823
Assignees
Labels
feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-Linux QA/Yes release-notes/include

Comments

@petemill
Copy link
Member

After the initial count of NTP view to see the first NTT (currently set to 2nd NTP view), there should be additional opportunities for NTT on every 3rd NTP view. Currently this is set to on every 4th NTP view.

@btlechowski
Copy link

Verified with

Brave 1.60.87 Chromium: 118.0.5993.70 (Official Build) beta (64-bit)
Revision 854c1e600054dfca6842cebaf729f100f4b0f066
OS Linux

opted out

Verified initial NTP SI is on 2nd tab:
image

Verified subsequent NTP SI are every 3rd tab:

image image

opted in

Verified initial NTP SI is on 2nd tab:
image

Verified subsequent NTP SI are every 3rd tab:

image image

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 23, 2023
@hffvld
Copy link
Contributor

hffvld commented Oct 23, 2023

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 U1B1.230908.003 release-keys]
Brave build: 1.60.96 
Chromium: 118.0.5993.88 (Official Build) beta (64-bit) 
Revision: b4c059ad1d32d6e0cd1466123f03ccb97b3cf858

Filed follow-up issue #33837

Fresh install

STEPS:

  1. Fresh install and launch Brave
  2. Go through onboarding until you land on NTP
  3. Open new tab > Confirm that 1st NTP SI is shown on the 2nd NTP
  4. Open a few more now tabs > Confirm that all next NTP SI is shown on the 3rd NTP
  5. Close and restart Brave > Open a few tabs > Verify
  6. Enable Brave News > Open a few tabs > Verify
  7. Enable Brave Rewards > Open a few tabs > Verify

ACTUAL RESULTS:

  • Verified that the 1st NTP SI is shown on the 2nd NTP and all following NTP SI are shown on the 3rd NTP.
  • Verified that restarting Brave is resetting the counter for the NTP SI.
  • Verified the same behavior after enabling Brave News
  • Verified the same behavior after enabling Brave Rewards

2023-10-23_10-22-53.mp4
Upgrade install

STEPS:

  1. Install build 1.59.x and launch Brave
  2. Go through onboarding until you land on NTP
  3. Open a few NTP > Confirm that 1st NTP SI is shown on the 2nd NTP and all following on the 4th NTP
  4. Now upgrade Brave to build 1.60.96 and launch it
  5. Open a few NTP > Confirm that 1st NTP SI is shown on the 2nd NTP and all following on the 3rd NTP

ACTUAL RESULTS:

  • Verified that the 1st NTP SI is shown on the 2nd NTP and all following NTP SI are shown on the 3rd NTP.
  • Verified that restarting Brave is resetting the counter for the NTP SI.

2023-10-23_11-09-49.mp4

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-Linux QA/Yes release-notes/include
Projects
None yet
5 participants