Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 118.0.5993.88 to Chromium 118.0.5993.96 #33752

Closed
emerick opened this issue Oct 19, 2023 · 3 comments · Fixed by brave/brave-core#20607
Closed

Upgrade from Chromium 118.0.5993.88 to Chromium 118.0.5993.96 #33752

emerick opened this issue Oct 19, 2023 · 3 comments · Fixed by brave/brave-core#20607
Assignees
@emerick @mkarolin
Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Desktop OS/macOS QA Pass-macOS QA Pass-macOS-arm64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.59.x - Release #3

Comments

@emerick
Copy link
Contributor

emerick commented Oct 19, 2023

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/118.0.5993.88..118.0.5993.96?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@emerick emerick added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Desktop labels Oct 19, 2023
This was referenced Oct 19, 2023
Merged
Merged
Merged
@kjozwiak kjozwiak added OS/macOS and removed OS/Android Fixes related to Android browser functionality labels Oct 20, 2023
@kjozwiak
Copy link
Member

The above requires 1.59.122 or higher for 1.59.x verification 👍

@kjozwiak kjozwiak mentioned this issue Oct 20, 2023
Closed
@kjozwiak
Copy link
Member

Verification **PASSED** on macOS 14.0 x64 Sonoma` using the following build(s):

Brave | 1.59.122 Chromium: 118.0.5993.96 (Official Build) (x86_64)
--- | ---
Revision  |7f846c30645dc849ba79b64c1f1ea43622f7d866
OS | macOS Version 14.0 (Build 23A344)

Screenshot 2023-10-20 at 11 42 37 AM

@stephendonner
Copy link

stephendonner commented Oct 20, 2023 •
edited
Loading

Verified PASSED using

Brave | 1.59.122 Chromium: 118.0.5993.96 (Official Build) (arm64)
-- | --
Revision | 7f846c30645dc849ba79b64c1f1ea43622f7d866
OS | macOS Version 13.6 (Build 22G120)
Screenshot 2023-10-20 at 10 58 27 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

@mkarolin mkarolin

Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Desktop OS/macOS QA Pass-macOS QA Pass-macOS-arm64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.59.x - Release #3
Development

Successfully merging a pull request may close this issue.

Upgrade from Chromium 118.0.5993.88 to Chromium 118.0.5993.96 brave/brave-core
5 participants
@stephendonner @kjozwiak @emerick @mkarolin @brave-builds