Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ? from the BAT icon #33922

Closed
anthonypkeane opened this issue Oct 25, 2023 · 1 comment · Fixed by brave/brave-core#21455
Closed

Remove ? from the BAT icon #33922

anthonypkeane opened this issue Oct 25, 2023 · 1 comment · Fixed by brave/brave-core#21455
Assignees
@deeppandya
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include
Projects
Brave Rewards
Milestone
1.63.x - Release

Comments

@anthonypkeane
Copy link

anthonypkeane commented Oct 25, 2023 •
edited
Loading

Description

Please remove the ? from the BAT icon and show it again after day 7 for 7 days

Screenshot_20231025-150447
@anthonypkeane anthonypkeane added the OS/Android Fixes related to Android browser functionality label Oct 25, 2023
@Miyayes Miyayes added this to New Issues in Brave Rewards via automation Oct 26, 2023
@deeppandya deeppandya self-assigned this Nov 1, 2023
@deeppandya deeppandya added priority/P3 The next thing for us to work on. It'll ride the trains. priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Nov 1, 2023
@deeppandya deeppandya mentioned this issue Dec 22, 2023
Merged
25 tasks
@Miyayes Miyayes moved this from New Issues to In progress in Brave Rewards Jan 10, 2024
Brave Rewards automation moved this from In progress to Done Jan 15, 2024
@brave-builds brave-builds added this to the 1.63.x - Nightly milestone Jan 15, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 8, 2024
@hffvld
Copy link
Contributor

hffvld commented Feb 8, 2024

Verified on Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Galaxy Tab S8 / gts8wifixx-user 13 TP1A.220624.014 release-keys
- Pixel 7 / panther_beta-user 14 AP11.231215.009 release-keys
Brave build: 1.63.146
Chromium: 121.0.6167.139 (Official Build) beta (64-bit)

STEPS:

  1. Install and launch Brave 1.63.146 or newer
  2. Go through the onboarding flow > After landing on NTP verify that no ? is shown on the Rewards icon
  3. Close the app > Go to the device settings and change the date to 1 - 6 days from today
  4. Launch Brave > Verify that no ? is shown on the Rewards icon
  5. Close the Brave and change date to 7 - 14 days from today
  6. Launch Brave > Verify that ? is shown on the Rewards icon
  7. Close the Brave and change date to 15+ days from today
  8. Launch Brave > Verify that no ? is shown on the Rewards icon

ACTUAL RESULTS:

  • Verified that ? is NOT shown on the Rewards icon after Brave's initial launch
  • Verified that ? is NOT shown on the Rewards icon for the first 1 - 6 days from today
  • Verified that ? is shown on the Rewards icon for the next 7 - 14 days from today
  • Verified that ? is NOT shown on the Rewards icon after 15+ days from today
  • Verified that tapping on ? is removing it permanently

Galaxy Tab S8

2024-02-07_17-09-15.mp4

Pixel 7

2024-02-07_16-49-07.mp4

@hffvld hffvld added QA Pass - Android ARM QA Pass - Android Tab and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 8, 2024
@kjozwiak kjozwiak mentioned this issue Feb 29, 2024
Closed
@deeppandya deeppandya mentioned this issue Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include
Projects
Brave Rewards
  
Done
Milestone
1.63.x - Release
Development

Successfully merging a pull request may close this issue.

Remove rewards onboarding icon brave/brave-core
6 participants
@kjozwiak @deeppandya @anthonypkeane @Miyayes @brave-builds @hffvld