Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Center Wallet Navigation and Body Together #34471

Closed
Douglashdaniel opened this issue Nov 21, 2023 · 1 comment · Fixed by brave/brave-core#21719
Closed

Center Wallet Navigation and Body Together #34471

Douglashdaniel opened this issue Nov 21, 2023 · 1 comment · Fixed by brave/brave-core#21719
Assignees
@Douglashdaniel
Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop polish Nice to have — usually related to front-end/visual tasks QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.64.x - Release

Comments

@Douglashdaniel
Copy link

Description

We need to center the Wallet Navigation and Body together to match the new designs.

Screenshot 19
@Douglashdaniel Douglashdaniel added enhancement polish Nice to have — usually related to front-end/visual tasks QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Nov 21, 2023
@Douglashdaniel Douglashdaniel self-assigned this Nov 21, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Dec 6, 2023
Merged
25 tasks
@Douglashdaniel Douglashdaniel mentioned this issue Jan 23, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.64.x - Nightly milestone Jan 24, 2024
@srirambv
Copy link
Contributor

srirambv commented Mar 1, 2024

Verification passed on

Brave 1.64.90 Chromium: 122.0.6261.94 (Official Build) beta (64-bit)
Revision 726c6970a1e9c057c69d80e03ad95a7c561fbfe7
OS Windows 11 Version 23H2 (Build 22631.3155)
  • Verified steps from brave/brave-core#21719
  • Verified wallet navigation and card body are both centre aligned
  • Verified reducing the browser size continues to centre wallet navigation and card body
34471.mp4

@LaurenWags LaurenWags mentioned this issue Mar 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop polish Nice to have — usually related to front-end/visual tasks QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.64.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Center Nav and Body Together brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds