Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build out Composer UI Select Address Modal #34581

Closed
Douglashdaniel opened this issue Nov 28, 2023 · 1 comment · Fixed by brave/brave-core#22720
Closed

Build out Composer UI Select Address Modal #34581

Douglashdaniel opened this issue Nov 28, 2023 · 1 comment · Fixed by brave/brave-core#22720
Assignees
@Douglashdaniel
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.66.x - Release

Comments

@Douglashdaniel
Copy link

Douglashdaniel commented Nov 28, 2023 •
edited

Description

We need to build out the new Composer UI Select Address Modal

Screenshot 22
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Nov 28, 2023
@Douglashdaniel Douglashdaniel self-assigned this Nov 28, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Dec 6, 2023
Merged
25 tasks
@Douglashdaniel Douglashdaniel mentioned this issue Mar 22, 2024
Merged
24 tasks
@Douglashdaniel Douglashdaniel changed the title Build out Composer UI Address Book Build out Composer UI Select Address Modal Mar 22, 2024
@brave-builds brave-builds added this to the 1.66.x - Nightly milestone Mar 26, 2024
@srirambv
Copy link
Contributor

srirambv commented May 6, 2024

Verification passed on

Brave 1.66.97 Chromium: 124.0.6367.118 (Official Build) beta (64-bit)
Revision 94909f2aaefd7a8137c8b4fa27235378e79231e3
OS Windows 11 Version 23H2 (Build 22631.3527)
  • Verified steps from brave/brave-core#22720
  • Verified new composer UI is shown for Select Address modal
  • Verified for valid/invalid/invalid extension/same address/missing checksum and offchain address resolution
34581.mp4

@srirambv srirambv mentioned this issue May 6, 2024
Closed
@LaurenWags LaurenWags mentioned this issue May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.66.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Composer UI Select Address Modal brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds