Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Route Params to Swap Screen #34725

Closed
Douglashdaniel opened this issue Dec 6, 2023 · 1 comment · Fixed by brave/brave-core#22266
Closed

Add Route Params to Swap Screen #34725

Douglashdaniel opened this issue Dec 6, 2023 · 1 comment · Fixed by brave/brave-core#22266
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.65.x - Release

Comments

@Douglashdaniel
Copy link

Description

We need to refactor the Swap screen to use route params similar to the Send screen.
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Dec 6, 2023
@Douglashdaniel Douglashdaniel self-assigned this Dec 6, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Dec 6, 2023
Merged
25 tasks
@Douglashdaniel Douglashdaniel mentioned this issue Feb 22, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Mar 7, 2024
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.65.96 Chromium: 123.0.6312.86 (Official Build) beta (64-bit)
Revision 5d9143e1a0812c53bdc27fd5384591254306a88c
OS Windows 11 Version 23H2 (Build 22631.3296)
  • Verified steps from brave/brave-core#22266
  • Verified filtering Portfolio by Account and clicking on More Menu for an asset and selecting Swap routes to Swap screen and pre-populates the token
  • Verified by changing tokens and networks works fine
  • Verified Select To button is disabled unless a From token is already selected
  • Verified Flip Tokens button is disabled until there is From Token and To Token selected
22266.mp4

@LaurenWags LaurenWags mentioned this issue Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.65.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Add Route Params to Swap Screen brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds