Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for removeparam in standard mode #35141

Closed
fmarier opened this issue Jan 4, 2024 · 3 comments · Fixed by brave/brave-core#21503
Closed

Improve support for removeparam in standard mode #35141

fmarier opened this issue Jan 4, 2024 · 3 comments · Fixed by brave/brave-core#21503
Assignees
Labels

Comments

@fmarier
Copy link
Member

fmarier commented Jan 4, 2024

Besides being used as privacy-harming tracking vectors (covered by Brave's own filter since 2019), query string parameters are also removed for other reasons in custom rule sets, and are involved in certain kinds of ads.

At the moment, support for removeparam rules in adblock lists is gated on users being in aggressive mode which means that:

  • removeparam rules added by users (directly in brave://settings/shields/filters or via a custom list) will be silently ignored unless the user also opts into aggressive mode
  • Video ads from SSAI (server-side ad insertion) systems will not be blocked in standard mode

Perhaps we can fix both of these limitations by adding a new metadata field to https://github.com/brave/adblock-resources/blob/master/filter_lists/list_catalog.json and gating removeparam on that instead.

@fmarier
Copy link
Member Author

fmarier commented Jan 10, 2024

For the release notes: Add support for removeparam in custom rules when adblocking is set to standard mode.

@stephendonner
Copy link

Verified PASSED using

Brave | 1.63.121 Chromium: 121.0.6167.57 (Official Build) nightly (x86_64)
-- | --
Revision | 875b8d7b36b12cd0707de7d638e05f9da6238ef5
OS | macOS Version 11.7.10 (Build 20G1427)

Steps:

  1. installed 1.63.121
  2. launched Brave
  3. loaded brave://adblock
  4. added ||example.com^$removeparam=test to the Custom Filters section
  5. clicked Save
  6. loaded https://example.com/?test=true

Confirmed that the ?test=true param was removed

example example example
Screen Shot 2024-01-16 at 9 35 16 AM Screen Shot 2024-01-16 at 9 36 25 AM Screen Shot 2024-01-16 at 9 36 48 AM

@hffvld
Copy link
Contributor

hffvld commented Feb 6, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP11.231215.009 release-keys
Brave build: 1.63.146
Chromium: 121.0.6167.139 (Official Build) beta (64-bit) 

Filed follow-up issue #35845

STEPS:

  1. Install and Launch Brave 1.63.146
  2. Go to brave://adblock OR Three-dot menu > Settings > Brave Shields & privacy > Content Filtering > Create custom filters
  3. Add ||example.com^$removeparam=test to the Custom Filters section > Save
  4. Go to https://example.com/?test=true > Verify that ?test=true must be removed from the URL search bar

ACTUAL RESULTS:

  • Verify that the URL bar must not contain ?test=true when Block trackers & ads in Standard mode
  • Observed that ?test=true is not removed from the URL search bar

1 2 3 4
1 2 3 4

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants