Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token to user tokens list when editing native asset visibility if token is not in list #35149

Closed
josheleonard opened this issue Jan 5, 2024 · 2 comments · Fixed by brave/brave-core#21498
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include

Comments

@josheleonard
Copy link
Collaborator

Description

Currently, in the edit visible token modal, we always list a network's native token, even when the user does not have that token in their tokens list. This prevents the asset's visibility to be changed. We should add the token to the user's token list when attempting to modify the token's visibility, so that we can track the visibility modification.

Steps to Reproduce

  1. Add a new chain to the wallet (do not add any new native assets)
  2. Open the visible assets modal
  3. hide the native asset
  4. refresh the page
  5. open the visible assets modal again

Actual result:

Asset will still be visible

Expected result:

Asset should be hidden

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@kjozwiak
Copy link
Member

The above requires 1.62.165 or higher for 1.62.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.62.165 Chromium: 121.0.6167.184 (Official Build) (64-bit)
Revision 646e9a49ef45084cb2341eb1e9afabc339004a27
OS Windows 11 Version 23H2 (Build 22631.3155)
  • Verified steps from issue description
  • Verified added user token visibility status is retained between page reloads
35149.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants