Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Redirect users to new custom filter settings #35269

Closed
deeppandya opened this issue Jan 11, 2024 · 1 comment · Fixed by brave/brave-core#21777
Closed

[Android] Redirect users to new custom filter settings #35269

deeppandya opened this issue Jan 11, 2024 · 1 comment · Fixed by brave/brave-core#21777
Assignees
@deeppandya
Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields.
Milestone
1.64.x - Release

Comments

@deeppandya
Copy link

Since we have the new filter list settings option: #26587
We need to redirect users to new filter list settings when they type brave://adblock in url bar.
@deeppandya deeppandya added webcompat/not-shields-related Sites are breaking because of something other than Shields. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels Jan 11, 2024
@deeppandya deeppandya self-assigned this Jan 11, 2024
@deeppandya deeppandya mentioned this issue Jan 26, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.64.x - Nightly milestone Jan 29, 2024
@Uni-verse
Copy link
Contributor

Uni-verse commented Mar 5, 2024 •
edited
Loading

Verified on Samsung Galaxy S21 & Samsung Galaxy Tab S7 using version:

Brave	1.64.95 Chromium: 122.0.6261.94 (Official Build) beta (64-bit) 
Revision	6f4193fbcee7c358ae3684f777faa9f12e52206e
OS	Android 13; Build/TP1A.220624.014; 33; REL
  • Ensured that typing brave://adblock redirects user to content filter page
  • Ensured direct is working in multi-window mode on Tablets.
Example Example
Screenshot 2024-03-05 at 6 32 22 PM Screenshot 2024-03-05 at 6 36 14 PM

@kjozwiak kjozwiak mentioned this issue Apr 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
None yet
Milestone
1.64.x - Release
Development

Successfully merging a pull request may close this issue.

Redirect users to new custom filter settings android brave/brave-core
3 participants
@deeppandya @Uni-verse @brave-builds