Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Have an option in filterlist section to force-update all adblock components #35270

Closed
deeppandya opened this issue Jan 11, 2024 · 3 comments · Fixed by brave/brave-core#23929
Closed

[Android] Have an option in filterlist section to force-update all adblock components #35270

deeppandya opened this issue Jan 11, 2024 · 3 comments · Fixed by brave/brave-core#23929
Assignees
@deeppandya
Labels
feature/components feature/settings OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields.
Milestone
1.67.x - Release

Comments

@deeppandya
Copy link

deeppandya commented Jan 11, 2024 •
edited
Loading

It would help adblock breakage remediation tremendously if users can force-update all adblock components by going to Settings-> Brave Shields & privacy -> Content Filtering and pressing a button instead of having to go to brave://components and clicking each Update button manually.

The button could live under the Filter lists section:

Action button text : Update
@deeppandya deeppandya added webcompat/not-shields-related Sites are breaking because of something other than Shields. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels Jan 11, 2024
@deeppandya deeppandya self-assigned this Jan 11, 2024
@deeppandya deeppandya mentioned this issue Mar 25, 2024
Closed
@deeppandya deeppandya changed the title [Android] Have button in filterlist section to force-update all adblock components [Android] Have an option in filterlist section to force-update all adblock components Mar 25, 2024
@deeppandya deeppandya mentioned this issue Apr 9, 2024
Closed
@deeppandya deeppandya mentioned this issue May 31, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 31, 2024
@brave-builds brave-builds mentioned this issue May 31, 2024
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Jun 7, 2024

The above requires 1.67.109 or higher for 1.67.x verification 👍

@superlex
Copy link

superlex commented Jun 7, 2024 •
edited
Loading

Uhm it looks like it doesn't work on my end.

It says that filter list has been updated:

Screenshot_20240607_232519_Brave.png

But it didn't:

Screenshot_20240607_232208_Brave.png

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 12, 2024
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 12, 2024 •
edited
Loading

Verification PASSED Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.67.110

  • Verified the test plan from Option to update filter list android brave-core#23929
  • ensured that there's a new UPDATE button available via Hamburger Menu -> Brave Shields & privacy -> Content Filtering
  • ensured that tapping UPDATE doesn't case any issues/crashes or visible regressions
XRecorder_12062024_195231.mp4

@GeetaSarvadnya GeetaSarvadnya added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 12, 2024
@kjozwiak kjozwiak mentioned this issue Jun 14, 2024
Closed
@hffvld hffvld mentioned this issue Jun 14, 2024
Closed
This was referenced Jun 27, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
feature/components feature/settings OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
None yet
Milestone
1.67.x - Release
Development

Successfully merging a pull request may close this issue.

Option to update filter list android brave/brave-core
5 participants
@superlex @kjozwiak @deeppandya @GeetaSarvadnya @brave-builds