Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A small gap (towards the left) between the edge and the header bar in an upgraded profile #35374

Closed
GeetaSarvadnya opened this issue Jan 17, 2024 · 3 comments

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #34702

A small gap (towards the left) between the edge and the header bar in an upgraded profile

Steps to Reproduce

  1. Clean profile 1.62.106
  2. Upgrade the profile to 1.63.120
  3. Open brave://settings
  4. A small gap (towards the left) between the edge and the header bar in an upgraded profile

Actual result:

A small gap (towards the left) between the edge and the header bar in an upgraded profile
image

Expected result:

RC - 1.61.x
image

Reproduces how often:

Easy

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Not sure
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @rebron @mkarolin

@GeetaSarvadnya
Copy link
Author

This issue exists in CR 120 also, I have upgraded profile from 1.63.106 to 1.63.119

image

@rebron
Copy link
Collaborator

rebron commented Jan 18, 2024

Closing as wontfix. Expected design #34229
brave://flags/#brave-horizontal-tabs-update can see the difference with this flag enabled which is 100% on for beta and nightly.

@cyraid
Copy link

cyraid commented Jul 25, 2024

Closing as wontfix. Expected design #34229 brave://flags/#brave-horizontal-tabs-update can see the difference with this flag enabled which is 100% on for beta and nightly.

@rebron With that setting disabled, the font remains in place (not centered), and gets clipped in vertical tabs. There really should be a change to have connected tabs (no gap #NoTabGap).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants