Upgrade from Chromium 120 to Chromium 121. #34702
Assignees
Labels
Chromium/upgrade major
Major version bump. (ex: Chromium 88 to 89)
feature/web3/wallet/core
feature/web3/wallet
Integrating Ethereum+ wallet support
OS/Android
Fixes related to Android browser functionality
OS/Desktop
QA/No
QA Pass - Android ARM
QA Pass - Android Tab
QA Pass-Win64
QA/Test-Plan-Specified
release-notes/exclude
Milestone
Comments
mkarolin
added
QA/Yes
release-notes/include
QA/Test-Plan-Specified
OS/Android
25 tasks
brave-builds
added
feature/web3/wallet
|
Verification PASSED on
Tab strip looks correct (vertical and horizontal)_PASSEDHorizontal Tabs
Vertical Tabs
Check that channel name is displayed correctly in brave://version (Beta, Nightly)_PASSED
Tor Use Bridges setting works_PASSED
HTTP -> HTTPS upgrade works_PASSEDCase 1_PASSED
Case 2_PASSEDDefault -
|
default |
insecure.arthuredelstein.net |
http.badssl.com |
upgradable.arthuredelstein.net |
|---|---|---|---|
Tor
insecure.arthuredelstein.net |
http.badssl.com |
upgradable.arthuredelstein.net |
|---|---|---|
Upgrade connections to HTTPS, Strict - PASSED
- installed
1.63.xCR121 - launched Brave
- changed
Upgrade connections to HTTPStoStrictinbrave://settings/shields - loaded
http://insecure.arthuredelstein.net - loaded
http://http.badssl.com - loaded
http://upgradable.arthuredelstein.net - opened a
New Private Window with Torand loaded each of the above
Upgrade connections, Strict |
insecure.arthuredelstein.net |
http.badssl.com |
upgradable.arthuredelstein.net |
|---|---|---|---|
Tor
insecure.arthuredelstein.net |
http.badssl.com |
upgradable.arthuredelstein.net |
|---|---|---|
Upgrade connections to HTTPS, Disabled - PASSED
- installed
1.63.xCR121 - launched Brave
- changed
Upgrade connections to HTTPStoDisabledinbrave://settings/shields - loaded
http://insecure.arthuredelstein.net - loaded
http://http.badssl.com - loaded
http://upgradable.arthuredelstein.net - opened a
New Private Window with Torand loaded each of the above
Upgrade connections, Disabled |
insecure.arthuredelstein.net |
http.badssl.com |
upgradable.arthuredelstein.net |
|---|---|---|---|
Tor
insecure.arthuredelstein.net |
http.badssl.com |
upgradable.arthuredelstein.net |
|---|---|---|
Rewards, Bookmarks, VPN, Wallet buttons in the toolbar look correctly_PASSED
Default settings/enabled
- Confirm that the
Rewards,Bookmarks,VPNandWalletsettings are enabled by default via brave://settings/appearance - Confirmed that the
Rewards,Bookmarks,VPNandWalletbuttons are shown correctly in the toolbar - Confirmed that click on each button works as expected
When the settings are disabled
- Disable
Rewards,Bookmarks,VPNandWalletsettings via brave://settings/appearance - Confirmed that the
Rewards,Bookmarks,VPNandWalletbuttons are not visible in the toolbar
Tor works with a proxy set_PASSED
Tor works with Proxy
To configure the Cloudflare DNS settings on Windows 10, I have followed the following steps:
- Open Start.
- Search for Control Panel
- Click on
Network and Internet - Click on
Network and Sharing Center - Click on
Change Adapter Settings - Right-click the active Wi-Fi or Ethernet adapter, and select the
Propertiesoption. - Select the
Internet Protocol Version 4 (TCP/IPv4)option. - Click the
Propertiesbutton. - Select the
Use the following DNS server addressesoption. - In the "Preferred DNS server" field, enter this IPv4 address:
1.1.1.1 - In the "Alternative DNS server" field, enter this IPv4 address:
1.0.0.1 - Click the OK button.
- Run
nslookupin cmd prompt and ensure that you are using Cloudflare DNS settings - Run the cases mentioned below in the
Tor works without Proxyand ensure that TOR works fine with the cloudfare proxy
| steps 1 to 13 | Example | Example | Example | Example |
|---|---|---|---|---|
| Example | Example |
|---|---|
| Example | Example |
|---|---|
Tor works without Proxy
- Clean profile 1.63.x CR121 build
- Ensured that the following domains opened in a Tor window without issues:
- brave.com
- duckduckgo.com
- https://duckduckgogg42xjoc72x3sjasowoarfbgcmvfimaftt6twagswzczad.onion/
- check.torproject.org (ensured that hard refreshing gets a new circuit/IP)
| Example | Example | Example | Example |
|---|---|---|---|
- Confirmed the following sites opened via "Open in Tor" button and navigated to .onion URL:
- brave.com --> https://brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/
- mail.protonmail.com --> https://protonmailrmez3lotccipshtkleegetolb73fuirgj7r4o4vfu7ozyd.onion/
| Example | Example |
|---|---|
| Example | Example |
|---|---|
Sidebar items and buttons look correctly_PASSED
- Confirmed that Sidebar items looks correctly on the sidebar
- Confirmed that click on each item on sidebar works as expected
Web discovery info bar looks correctly_PASSED
- Clean profile 1.63.x CR 121
- Open brave://settings/search
- Confirmed Brave is default search engine in brave://settings/search
- Enter a string "hello" in the URL bar
- Confirmed that Web discovery info bar is shown
- Confirmed that the Web discovery info bar looks correct and all the links/buttons on the info bar works as expected
Verify that "Copy link to text" menu item is not shown in context menu_PASSED
- Confirm that "Copy link to text" menu item is NOT shown in the context menu
Save As is shown in regular and OTR profiles when the setting is turned on_PASSED
Save As modal in regular profile
- installed 1.63.x CR121 build
- launch Brave
- Visit https://notepad-plus-plus.org/downloads/
- Click on
Downloadon any of the file - Confirm that
Save Asmodal popup is shown and file is saved under the path which is mentioned in the brave://settings/downloads settings
Save As modal in OTR profile
- installed 1.63.x CR121 build
- launch Brave
- set
brave://flags/#brave-request-otr-tabto Enabled - visited a request-OTR enrolled site: https://www.ceta.tech.cornell.edu/
- confirmed that the “would you like OTR mode” interstitial appears
- clicked
Proceed Off-The-Recordto go into OTR mode - confirmed that the requested page appears, and that there is an info bar at the top of the page describing how to leave OTR mode
- Visit https://notepad-plus-plus.org/downloads/
- Click on
Downloadon any of the file - Confirm that
Save Asmodal popup is shown and file is saved under the path which is mentioned in the brave://settings/downloads settings
| Example | Example |
|---|---|
brave://about_PASSED
Clean profile
- Install a standalone version which is behind the public nightly version
1.63.120 Chromium: 121.0.6167.57and open brave://settings/help and ensured that the correct version is shown - Confirmed that the channel name
nightlyis shown correctly - Confirmed that the correct architecture
64-bitis shown - Confirmed that the update is available, click on
Relaunchand confirmed that brave is updated to public nightly version - Confirmed that
Brave is up to datemessage is shown as brave is already updated to the public version and latest version from Omaha server is picked up correctly
1.63.120 Chromium: 121.0.6167.57 |
1.63.121 Chromium: 121.0.6167.57 |
|---|---|
Upgrade profile
Install two CR120 stand alone installers one after the other and ensure that brave is updated to the correct version
- Install
1.62.86 Chromium: 120.0.6099.35and confirm version details are shown correctly via brave://version and close the browser - Install
1.63.119 Chromium: 120.0.6099.217and confirm version details are shown correctly via brave://version and close the browser - Confirmed that channel name and architecture is shown correctly
1.62.86 Chromium: 120.0.6099.35 |
1.63.119 Chromium: 120.0.6099.217 |
|---|---|
- Open brave://settings/help and ensure that the update is available, click on
Relaunchand enure that brave is updated to public nightly version
1.63.119 Chromium: 120.0.6099.217 |
1.63.121 Chromium: 121.0.6167.57 |
|---|---|
- Confirmed that the channel name
nightlyis shown correctly - Confirmed that the correct architecture
64-bitis shown correctly - Confirmed that
Brave is up to datemessage is shown as brave is already updated to the public version and latest version from Omaha server is picked up correctly
Shields: script blocking and temporarily blocking works_PASSED
Case 1:
- Clean profile on Nightly 1.63.124
- Visit a site where things will be blocked (e.g Buzzfeed.com)
- See shields onboarding
- Confirmed that the onboarding is shown on the shield
- Confirmed the bubble auto dismissed at about 15seconds
Case 2:
- Clean profile on Nightly 1.63.124
- Visit a site where things are NOT blocked (e.g Brave.com)
- See shields onboarding
- Confirmed that the onboarding is NOT shown on the shield
New tab button looks correctly_PASSED
Clean profile
- Confirmed that click on
+new tab opens up the new tab in Regular window - Confirmed that click on
+new tab in PT opens up the new tab in Private window - Confirmed that click on
+new tab in TOR windows opens up the new tab in TOR Private window
Upgrade profle
- Encountered [CR121] - New tab button (
+) is misaligned on upgrade from C120 -> C121 and in new install as well #35300 - Confirmed that click on
+new tab opens up the new tab in Regular window - Confirmed that click on
+new tab in PT opens up the new tab in Private window - Confirmed that click on
+new tab in TOR windows opens up the new tab in TOR Private window
Settings UI cookies page (changed)_PASSED
- Cookies UI design is changed as part of CR121, In the CR121 build there is no "Block all" cookies settings in brave://settings/cookies, Also the setting
Clear cookies and site data when you close all windowsis removed as part of chromium 121 - The custom cookies settings are removed from the brave://settings/cookies page
- Currently there is only
Allowed to use third-party cookiesAdd custom cookies sites settings - Confirmed that user can add custom cookies sites under
Allowed to use third-party cookiesviaAddbutton - Confirmed that user can delete the added custom cookies sites by clicking on the trash icon
- Chromium cookies settings and shield settings are not in sync - Logged CR121 - Cookies settings are not in sync between
brave://settings/cookiesandbrave://settings/shieldssettings pages #35415 - Custom sites added in older profile are not retained in an upgraded CR121 profile - Logged CR 121 - Sites added under
Sites that can always use cookiesblock are not retained in an upgraded profile CR121 #35435
- Cookies settings are renamed to
Allow third-party cookiesandBlock third-party cookiesas part of CR121 - In a clean profile, open a site A, check the site info and confirm that 3rd party cookies are blocked on the site A, open brave://settings/cookies and change the cookies settings to
Allow third-party cookiesand then reload the site A check the cookies blocked count forsite A, the cookies blocked count is same, ideally it should not block any cookies on the site when "Allow 3rd party cookies" settings are selected, this issue is happening due to the issue CR121 - Cookies settings are not in sync betweenbrave://settings/cookiesandbrave://settings/shieldssettings pages #35415
Settings UI security page looks correctly_PASSED
Clean profile
- Confirmed that the new UI for the secure DNS settings is inherited from chromium 121
- Confirmed that new DNS are added into the
Select DNS providerdropdown - Confirmed that
OS dafault (when available)settings is selected by default in the dropdown - Confirmed that user can set different custom DNS
Disable the Use secure DNS in CR 120 and upgrade the profile to 121
- Install 1.63.119 CR 120 build
- Open brave://settings/security
- Disable
Use secure DNSsettings - Upgrade the profile to 1.63.x CR121 build
- Confirmed that the setting remained disabled in an upgraded profile
- Confirm that the text
Use secure DNSis replaced by the new chromium textEncrypt the names of sites you visit
| 1.63.119 | 1.63.124 |
|---|---|
Upgrade profile
- Install 1.63.119 CR 120 build
- Open brave://settings/security
- Select
cloudfare 1.1.1.1custom DNS or any other DNS - Upgrade the profile to 1.63.x CR121 build
- Confirmed that the updated settings
cloudfare 1.1.1.1custom DNS is retained in an upgraded profile
| 1.63.119 | 1.63.124 |
|---|---|
Settings comparison
- Confirmed that new settings are added in the
Select DNS providerdropdown as part of CR 121 under security Tab - Security page changes are verified as part of
Settings UI security page looks correctlycase above
- The
Cookies and other site datatext is renamed toThird-party cookiesin brave://settings/privacy page which is same as Chromium CR121 - The brave://settings/cookies page settings and removed and updated as part of CR 121 - Testing on cookies is covered in the case
Settings UI cookies page (changed)above. - Bookmarks Add modal popup is changed as part of CR121
- The
Brave Rewardssettings is removed from the brave://settings left navigation menu and the settingsShow Brave Rewards buttonis added via brave://settings/appearance as part of Brave
- The new content settings
On-device site dataadded as part of CR 121
Brave startup calls
- Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile
- Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile
24 tasks
This was referenced Jan 17, 2024
Closed
|
Verified on Lifetime options
Widevine
NTP Layout
New Bookmarks UI
New UI for switches
Encountered: #35335
Double check [Issue](https://github.com//issues/23433)
|
|
Verified on Lifetime options
Widevine
NTP Layout
New Bookmarks UI
New UI for switches
Encountered: #35335
Double check [Issue](https://github.com//issues/23433)
|
|
Labelling as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Upgrade from Chromium 120 to Chromium 121
https://chromium.googlesource.com/chromium/src/+log/120.0.6099.56..121.0.6156.3/?pretty=fuller&n=10000
QA tests:
This is a major Chromium version bump, please do full passes.
Desktop Affected areas:
Use Bridgessetting worksSave Asis shown in regular and OTR profiles when the setting is turned oniOS Affected areas:
TBD
Android Affected areas:
The text was updated successfully, but these errors were encountered: