Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option for submitting a screenshot when reporting webcompat issues #35473

Closed
ShivanKaul opened this issue Jan 22, 2024 · 4 comments · Fixed by brave/brave-core#22389
Closed
Assignees
Labels
OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include webcompat/reporter Bugs/features for Webcompat Reporter

Comments

@ShivanKaul
Copy link
Collaborator

It would be extremely helpful if the user could take a screenshot when reporting webcompat issues.

There would be a button on the Report Site form that on clicking would attach and send what the page currently looks like (below browser chrome without the Report Site overlay).

@ShivanKaul ShivanKaul added OS/Android Fixes related to Android browser functionality OS/Desktop webcompat/reporter Bugs/features for Webcompat Reporter labels Jan 22, 2024
@ShivanKaul ShivanKaul added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 1, 2024
@DJAndries DJAndries self-assigned this Feb 27, 2024
@DJAndries DJAndries added QA/Yes release-notes/exclude and removed OS/Android Fixes related to Android browser functionality labels Feb 29, 2024
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Mar 12, 2024
@stephendonner
Copy link
Collaborator

Verified PASSED using

Brave | 1.65.80 Chromium: 123.0.6312.29 (Official Build) nightly (64-bit)
-- | --
Revision | cd0c2b9c6f07e8f01724294c8d7e37393a8c3a38
OS | Windows 10 Version 22H2 (Build 19045.4170)

Steps:

  1. installed 1.65.80
  2. launched Brave
  3. loaded vox.com
  4. chose Help > Report a broken site
  5. filled out the form, checked the Include screenshot checkbox
  6. previewed the screenshot
  7. submitted the form
  8. repeated the above steps, without attaching a screenshot

With screenshot

example screenshot preview feedback submitted
image image image

Without screenshot

example feedback submitted
image image

@stephendonner
Copy link
Collaborator

@DJAndries hello! I'd like to be able to verify my above submissions; do you know where I can find them? (In particular, the submission with the screenshot, to be sure it was sent to the server.)

@DJAndries
Copy link
Collaborator

@DJAndries hello! I'd like to be able to verify my above submissions; do you know where I can find them? (In particular, the submission with the screenshot, to be sure it was sent to the server.)

will DM

@stephendonner
Copy link
Collaborator

Confirmed via our internal metrics/feedback system that the screenshot was indeed attached:

example example example
Screen Shot 2024-03-14 at 8 25 00 PM Screen Shot 2024-03-14 at 8 25 13 PM Screen Shot 2024-03-14 at 8 21 58 PM

@rebron rebron changed the title Let user take screenshots when reporting webcompat issues Add an option for submitting a screenshot when reporting webcompat issues Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include webcompat/reporter Bugs/features for Webcompat Reporter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants