Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gas estimates when gas fields are changed #35518

Closed
josheleonard opened this issue Jan 23, 2024 · 1 comment · Fixed by brave/brave-core#21708
Closed

update gas estimates when gas fields are changed #35518

josheleonard opened this issue Jan 23, 2024 · 1 comment · Fixed by brave/brave-core#21708

Comments

@josheleonard
Copy link
Collaborator

Description

We should refetch the gas estimates when the user changes any gas setting.

Steps to Reproduce

  1. create a new EVM transaction
  2. edit the gas setting for the transaction

Actual result:

the gas estimates do not immediately refresh

Expected result:

the gas estimates should refresh

Reproduces how often:

Easy

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.64.102 Chromium: 122.0.6261.111 (Official Build) beta (64-bit)
Revision c9343c77bd5dee3524fc45f89721ce0bf4c09b8d
OS Windows 11 Version 23H2 (Build 22631.3155)
  • Verified steps from issue description
  • Verified gas estimates is updated when gas fields are changed
35518.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants