Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial onboarding screen when accessing Brave Wallet #35713

Closed
simoarpe opened this issue Jan 31, 2024 · 1 comment · Fixed by brave/brave-core#21905
Closed

Initial onboarding screen when accessing Brave Wallet #35713

simoarpe opened this issue Jan 31, 2024 · 1 comment · Fixed by brave/brave-core#21905
Assignees
@simoarpe
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.64.x - Release

Comments

@simoarpe
Copy link
Collaborator

image

Figma design: https://www.figma.com/file/oXIiv45pIhF2RGlpEjOfUg/Wallet-onboarding?node-id=6223%3A70942&mode=dev

Main umbrella issue: #35294

Description

Redesign initial onboarding screen when accessing Brave Wallet for the first time.
Include new screen for accepting T&Cs.

Additional information

Remove copyright footer.
Share background gradient values with William.
@simoarpe simoarpe added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Jan 31, 2024
This was referenced Jan 31, 2024
Open
Merged
@brave-builds brave-builds added this to the 1.64.x - Nightly milestone Feb 7, 2024
@simoarpe simoarpe self-assigned this Feb 9, 2024
@srirambv
Copy link
Contributor

Verification passed on Google Pixel 8 with Android 14 and Lenovo Tab with Android 13 running 1.64.97 x64 Beta build

  • Verified steps from brave/brave-core#21905
  • Verified new onboarding screen is shown when creating a wallet
  • Verified selecting both terms enables Continue button
  • Verified Terms of use clickable span points to https://brave.com/terms-of-use/
  • Verified onboarding screen looks correct on both dark and light theme

@kjozwiak kjozwiak mentioned this issue Apr 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoarpe simoarpe

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.64.x - Release
Development

Successfully merging a pull request may close this issue.

(Wallet) Implement onboarding initial screen and TOC screen brave/brave-core
3 participants
@simoarpe @srirambv @brave-builds