Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect back up wallet action from WebUI to native backup screen #35928

Closed
simoarpe opened this issue Feb 9, 2024 · 1 comment · Fixed by brave/brave-core#21984
Closed

Connect back up wallet action from WebUI to native backup screen #35928

simoarpe opened this issue Feb 9, 2024 · 1 comment · Fixed by brave/brave-core#21984
Assignees
@simoarpe
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.65.x - Release

Comments

@simoarpe
Copy link

simoarpe commented Feb 9, 2024 •
edited
Loading

image__16_

Figma design: https://www.figma.com/file/oXIiv45pIhF2RGlpEjOfUg/Wallet-onboarding?node-id=6223%3A70942&mode=dev

Main umbrella issue: #35294

Description

Launch native UI to back up Brave Wallet when tapping on "Back up now" button.

Additional information

Android will open native UI, while desktop will keep the behavior unchanged and will navigate to brave://wallet/crypto/backup-wallet
@simoarpe simoarpe added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Feb 9, 2024
@simoarpe simoarpe self-assigned this Feb 9, 2024
@simoarpe simoarpe changed the title Connect backup wallet action from WebUI to native backup screen Connect back up wallet action from WebUI to native backup screen Feb 9, 2024
This was referenced Feb 9, 2024
Merged
Open
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Feb 27, 2024
@srirambv
Copy link
Contributor

srirambv commented Apr 4, 2024

Verification passed on Google Pixel 8 with Android 14 running 1.65.96 x64 Beta build

  • Verified steps from brave/brave-core#21984
  • Verified selecting Backup from banner on portfolio brings up native UI
  • Verified completing backup removes the banner permanently

@kjozwiak kjozwiak mentioned this issue Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoarpe simoarpe

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.65.x - Release
Development

Successfully merging a pull request may close this issue.

(Wallet) Connect back up wallet action from WebUI to native backup screen brave/brave-core
3 participants
@simoarpe @srirambv @brave-builds