Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SNS V2 Records #35958

Closed
supermassive opened this issue Feb 12, 2024 · 3 comments · Fixed by brave/brave-core#22443
Closed

Support SNS V2 Records #35958

supermassive opened this issue Feb 12, 2024 · 3 comments · Fixed by brave/brave-core#22443
Assignees
@supermassive
Labels
feature/web3/ddns feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.64.x - Release

Comments

@supermassive
Copy link
Collaborator 

Here is the documentation: https://sns.guide/domain-name/records/records-v2.html
Domain: 7059.sol has a URL record set on Records V2
@supermassive supermassive added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop feature/web3/ddns labels Feb 12, 2024
@supermassive supermassive self-assigned this Feb 12, 2024
@yrliou yrliou added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include labels Feb 21, 2024
@supermassive supermassive mentioned this issue Mar 4, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Mar 12, 2024
@supermassive supermassive mentioned this issue Mar 13, 2024
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.64.105 or higher for 1.64.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on Google Pixel 8 with Android 14 running 1.64.105 x64 Nightly build

  • Verified steps from brave/brave-core#22443
  • Verified sub-0.wallet-guide-3.sol resolves address to Fxuoy3gFjfJALhwkRcuKjRdechcgffUApeYAfMWck6w8
  • Verified sub-1.wallet-guide-3.sol resolves address to Hf4daCT4tC2Vy9RCe9q8avT68yAsNJ1dQe6xiQqyGuqZ
  • Verified wallet-guide-8.sol resolves address to 36Dn3RWhB8x4c83W6ebQ2C2eH9sh5bQX2nMdkP2cWaA4
  • Verified wallet-guide-6.sol resolves address to Hf4daCT4tC2Vy9RCe9q8avT68yAsNJ1dQe6xiQqyGuqZ
  • Verified wallet-guide-9.sol resolved to domain ipfs://test
  • Verified 7059.sol doesn't resolve as domain record is not valid
  • Verified bonfida.sol resolve to domainhttps://sns.id
35958.mp4

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.64.105 Chromium: 123.0.6312.46 (Official Build) (64-bit)
Revision f0e46384b4e277529e9123c93370e113c547e206
OS Windows 11 Version 23H2 (Build 22631.3296)
  • Verified steps from brave/brave-core#22443
  • Verified sub-0.wallet-guide-3.sol resolves address to Fxuoy3gFjfJALhwkRcuKjRdechcgffUApeYAfMWck6w8
  • Verified sub-1.wallet-guide-3.sol resolves address to Hf4daCT4tC2Vy9RCe9q8avT68yAsNJ1dQe6xiQqyGuqZ
  • Verified wallet-guide-8.sol resolves address to 36Dn3RWhB8x4c83W6ebQ2C2eH9sh5bQX2nMdkP2cWaA4
  • Verified wallet-guide-6.sol resolves address to Hf4daCT4tC2Vy9RCe9q8avT68yAsNJ1dQe6xiQqyGuqZ
  • Verified wallet-guide-9.sol resolved to domain ipfs://test
  • Verified 7059.sol doesn't resolve as domain record is not valid
  • Verified bonfida.sol resolve to domainhttps://sns.id
35958.mp4

@LaurenWags LaurenWags mentioned this issue Mar 18, 2024
Closed
@kjozwiak kjozwiak mentioned this issue Apr 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supermassive supermassive

Labels
feature/web3/ddns feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.64.x - Release
Development

Successfully merging a pull request may close this issue.

SNS Record v2 brave/brave-core
5 participants
@supermassive @kjozwiak @yrliou @srirambv @brave-builds