Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Close Duplicate Tabs to main Tab menu on macOS and tab context menu (on all platforms) #36041

Closed
yrliou opened this issue Feb 13, 2024 · 3 comments · Fixed by brave/brave-core#22041
Closed

Add Close Duplicate Tabs to main Tab menu on macOS and tab context menu (on all platforms) #36041

yrliou opened this issue Feb 13, 2024 · 3 comments · Fixed by brave/brave-core#22041
Assignees
@yrliou
Labels
feature/context-menu OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.65.x - Release

Comments

@yrliou
Copy link
Member

yrliou commented Feb 13, 2024 •
edited

main menu on mac:
Screenshot 2024-02-13 at 3 07 04 PM

tab context menu:
Screenshot 2024-02-13 at 3 06 09 PM

cc @rebron
@yrliou yrliou self-assigned this Feb 13, 2024
@yrliou yrliou mentioned this issue Feb 13, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Feb 14, 2024
@rebron rebron mentioned this issue Feb 14, 2024
Open
@rebron rebron changed the title Add Close Duplicate Tabs to main menu on mac and tab context menu Add Close Duplicate Tabs to main Tab menu on macOS and tab context menu (on all platform) Feb 15, 2024
@rebron rebron changed the title Add Close Duplicate Tabs to main Tab menu on macOS and tab context menu (on all platform) Add Close Duplicate Tabs to main Tab menu on macOS and tab context menu (on all platforms) Feb 15, 2024
@rebron rebron added this to Completed in Front End Feb 20, 2024
@stephendonner
Copy link
Collaborator

stephendonner commented Mar 20, 2024 •
edited

Verification PASSED using

Brave	1.65.88 Chromium: 123.0.6312.58 (Official Build) beta (x86_64) 
Revision	e260e641e7db9e88b9b51112f4f00febf5a2f5eb
OS	macOS Version 11.7.10 (Build 20G1427)

Case 1: Top-level macOS menu-item - PASSED

Steps:

  1. installed 1.65.88
  2. launched Brave
  3. loaded example.com/a in a new tab, Tab 1
  4. loaded example.com/b in a new tab, Tab 2 (same window)
  5. clicked on the top-level Tab menu item
  6. confirmed Close Duplicate Tabs was greyed-out/ghosted
  7. loaded example.com/a in a new tab, Tab 3 (same window)
  8. clicked on the top-level Tab menu item
  9. confirmed Close Duplicate Tabs was enabled
  10. clicked on Close Duplicate Tabs
  11. confirmed Tab 3 was closed
  12. context-clicked on Tab 2

Confirmed Close Duplicate Tabs was again greyed-out/ghosted, with only example.com/a and example.com/b tabs remaining

example example example example example
Screen Shot 2024-03-20 at 1 52 17 PM Screen Shot 2024-03-20 at 1 52 52 PM Screen Shot 2024-03-20 at 1 53 02 PM Screen Shot 2024-03-20 at 1 53 11 PM Screen Shot 2024-03-20 at 1 53 21 PM

Case 2: Context-menu item - PASSED

Steps:

  1. installed 1.65.88
  2. launched Brave
  3. loaded example.com/a in Tab 1
  4. loaded example.com/b in a new tab, Tab 2 (same window)
  5. context-clicked on Tab 1
  6. confirmed Close Duplicate Tabs was greyed out/ghosted
  7. loaded example.com/a in a new tab, Tab 3 (same window)
  8. context-clicked on Tab 3
  9. clicked on Close Duplicate Tabs
  10. confirmed Tab 3 closed; I was left with unique-URL tabs:Tab 1 (example.com/a) and Tab 2 (example.com/b)
  11. opened a new window
  12. loaded example.com/a
  13. context-clicked on the above tab
  14. confirmed Close Duplicate Tabs was greyed out/ghosted

Same window

example example
Screen Shot 2024-03-20 at 1 34 34 PM Screen Shot 2024-03-20 at 1 34 46 PM

New window

Screen Shot 2024-03-20 at 1 42 40 PM

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 20, 2024
@MadhaviSeelam
Copy link
Collaborator

MadhaviSeelam commented Mar 25, 2024 •
edited

Verification PASSED using

Brave | 1.65.89 Chromium: 123.0.6312.58 (Official Build) beta (64-bit)
-- | --
Revision | 2975bd8d3905ed79de82dd9fa11b6e4019075dd6
OS | Windows 11 Version 23H2 (Build 22631.3296)

Steps:

Case 1: New install - Horizontal tabs - PASSED

  1. Installed 1.65.89
  2. launched Brave
  3. visited site 1 (cnn.com) and visited site 2(chevron.com)
  4. context clicked on both tabs
  5. confirmed Close Duplicate Tabs was greyed out/inactive
  6. added few duplicate tabs for site 1 & site 2
  7. context clicked on one of the tabs for site 2
  8. clicked Close Duplicate Tabs
  9. confirmed duplicate tabs are closed for site 2 and left with unique tab.
  10. pinned tabs for site 1
  11. follow step 7-8
  12. confirmed pinned duplicate tabs are closed for site 1 and left with unique pinned tab
step 3 step 4 step 6-8 step 10 - 11 step 12
image image image image image

Case 2: New Window - Dark theme - PASSED

  1. continued from Case 1
  2. opened a new window via hamburger menu
  3. switch to Dark theme via brave://settings/appearance
  4. visited a site in a new tab (chevron.com)
  5. confirmed Close Duplicate Tabs was greyed out/inactive
  6. opened a few duplicate tabs
  7. confirmed Close Duplicate Tabs was active
  8. clicked Close Duplicate Tabs
  9. confirmed duplicate tabs are closed for site 2 and left with unique tab.
step 3- 5 step 7-8 step 9
image image image

Case 3: Upgrade - Vertical tabs - PASSED

  1. Installed 1.64.109
  2. launched Brave
  3. visited site 1 (theguardian.com) and visited site 2(bbc.com)
  4. enabled vertical tabs via context menu
  5. opened few duplicate tabs for site 2
  6. verified Close Duplicate Tabs option is not available in 1.64.x
  7. closed Brave
  8. installed 1.65.89
  9. renamed above Brave profile Brave-Browser-Beta
  10. launched Brave Beta
  11. opened context menu of a tab for site 2
  12. clicked Close Duplicate Tabs option
  13. confirmed duplicate tabs are closed for site 2 and left with unique tab
  14. added few duplicate tabs for site and created News group
  15. opened context menu and clicked Closed Duplicate Tabs option
  16. confirmed duplicate tabs are closed for site 1 and left with unique tab
step 1 step 4-6 step 8-10 step 12 step 13 step 14 step 16
image image image image image image image

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 1, 2024
@stephendonner
Copy link
Collaborator

stephendonner commented Apr 1, 2024 •
edited

Verification PASSED

using

Brave	1.65.100 Chromium: 123.0.6312.86 (Official Build) beta (64-bit) 
Revision	8456ab291d9c823aaff5de460a63b53485320488
OS	Linux

Case 1: New install - Horizontal tabs - PASSED

  1. installed 1.65.100
  2. launched Brave
  3. visited site 1 (cnn.com) and visited site 2 (bp.com)
  4. context clicked on both tabs
  5. confirmed Close Duplicate Tabs was greyed out/inactive
  6. added few duplicate tabs for site 1 & site 2
  7. context clicked on one of the tabs for site 2
  8. clicked Close Duplicate Tabs
  9. confirmed duplicate tabs are closed for site 2 and left with unique tab.
  10. pinned tabs for site 1
  11. follow step 7-8
  12. confirmed pinned duplicate tabs are closed for site 1 and left with unique pinned tab
step 3 step 4 step 6-8 step 10 - 11 step 12
Screen Shot 2024-04-01 at 2 45 36 PM Screen Shot 2024-04-01 at 2 44 34 PM Screen Shot 2024-04-01 at 2 48 53 PM Screen Shot 2024-04-01 at 2 56 12 PM Screen Shot 2024-04-01 at 2 56 17 PM

Case 2: New Window - Dark theme - PASSED

  1. continued from Case 1
  2. opened a new window via hamburger menu
  3. switch to Dark theme via brave://settings/appearance
  4. visited a site in a new tab (chevron.com)
  5. confirmed Close Duplicate Tabs was greyed out/inactive
  6. opened a few duplicate tabs
  7. confirmed Close Duplicate Tabs was active
  8. clicked Close Duplicate Tabs
  9. confirmed duplicate tabs are closed for site 2 and left with unique tab.
step 3- 5 step 7-8 step 9
Screen Shot 2024-04-01 at 3 02 37 PM Screen Shot 2024-04-01 at 3 03 43 PM Screen Shot 2024-04-01 at 3 03 46 PM

Case 3: Upgrade - Vertical tabs - PASSED

  1. Installed 1.64.113
  2. launched Brave
  3. visited site 1 (theguardian.com) and visited site 2 (bbc.com)
  4. enabled vertical tabs via context menu
  5. opened few duplicate tabs for site 2
  6. verified Close Duplicate Tabs option is not available in 1.64.x
  7. closed Brave
  8. installed 1.65.100
  9. renamed above Brave-Browser profile to Brave-Browser-Beta
  10. launched Brave Beta
  11. opened context menu of a tab for site 2
  12. clicked Close Duplicate Tabs option
  13. confirmed duplicate tabs are closed for site 2 and left with unique tab
  14. added few duplicate tabs for site and created News group
  15. opened context menu and clicked Closed Duplicate Tabs option
  16. confirmed duplicate tabs are closed for site 1 and left with unique tab
step 1 step 4-6 step 8-10 step 12 step 13 step 14 step 16
Screen Shot 2024-04-01 at 3 10 48 PM Screen Shot 2024-04-01 at 3 29 48 PM Screen Shot 2024-04-01 at 3 16 36 PM Screen Shot 2024-04-01 at 3 34 18 PM Screen Shot 2024-04-01 at 3 34 42 PM Screen Shot 2024-04-01 at 3 35 29 PM Screen Shot 2024-04-01 at 3 39 13 PM

@stephendonner stephendonner added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 1, 2024
@LaurenWags LaurenWags mentioned this issue Apr 15, 2024
Closed
@rebron rebron removed this from Completed in Front End Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yrliou yrliou

Labels
feature/context-menu OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.65.x - Release
Development

Successfully merging a pull request may close this issue.

Add Close Duplicate Tabs into Tab menu on Mac and tab context menu (all platforms) brave/brave-core
5 participants
@stephendonner @yrliou @rebron @brave-builds @MadhaviSeelam