Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Leo right-click quick actions #36159

Closed
LorenzoMinto opened this issue Feb 16, 2024 · 4 comments · Fixed by brave/brave-core#22090
Closed

Add Leo right-click quick actions #36159

LorenzoMinto opened this issue Feb 16, 2024 · 4 comments · Fixed by brave/brave-core#22090
Assignees
@yrliou
Labels
browser-ai OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.64.x - Release

Comments

@LorenzoMinto
Copy link
Member

LorenzoMinto commented Feb 16, 2024 •
edited by rebron

Spec: https://docs.google.com/document/d/1NsMwFlalPNAv3rzV1siaHCaonbrIbvSua6t-E7fvfKE/edit
Figma: https://www.figma.com/file/m0Gdbf0wtqyfEFGm32VLLc/Leo?node-id=2240%3A14540&mode=dev
(Note that some things are not in the first phase.)

Related information

Follow-up issues:
@LorenzoMinto LorenzoMinto mentioned this issue Feb 16, 2024
Merged
24 tasks
@yrliou yrliou added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 21, 2024
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Feb 23, 2024
This was referenced Mar 1, 2024
Merged
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Mar 5, 2024

The above requires 1.64.96 or higher for 1.64.x verification 👍

@stephendonner
Copy link
Collaborator

stephendonner commented Mar 6, 2024 •
edited

Verification PASSED using

Brave | 1.64.96 Chromium: 122.0.6261.111 (Official Build) beta (x86_64)
-- | --
Revision | fb9feca2d1f25ea20265752e8ecdf548a6925bd4
OS | macOS Version 11.7.10 (Build 20G1427)

1. Leo AI Tools context-menu invocations (high-level) - PASSED

Opted-out - PASSED

No text highlighted, context-click action

Steps:

  1. installed 1.64.96
  2. launched Brave
  3. loaded skynews.com
  4. context-clicked on an empty region

Confirmed no Leo AI Tools submenu in the invoked context-menu

Screen Shot 2024-03-06 at 12 55 45 PM

Text highlighted, context-click action

Steps:

  1. installed 1.64.96
  2. launched Brave
  3. loaded skynews.com
  4. selected headline
  5. context-clicked on the page
  6. chose Summarize from the flyout Brave AI tools > menu
  7. clicked I understand in the opened Leo pane

Confirmed Leo AI Tools context-menu item appears, with flyout, in the invoked context-menu

example example
Screen Shot 2024-03-06 at 12 46 52 PM Screen Shot 2024-03-06 at 12 47 04 PM

Opted-in - PASSED

No text highlighted, context-click action

Steps:

  1. installed 1.64.96
  2. launched Brave
  3. loaded example.com
  4. clicked Summarize this page
  5. clicked I understand
  6. context-clicked on an empty region

Confirmed no Leo AI Tools submenu in the invoked context-menu

Screen Shot 2024-03-06 at 1 00 54 PM

Text highlighted, context-click action

example example
Screen Shot 2024-03-06 at 1 03 05 PM Screen Shot 2024-03-06 at 1 05 06 PM

Shared Steps:

  1. installed 1.64.96
  2. launched Brave
  3. loaded various pages (see screenshots in each respective section)
  4. selected a portion of the text on the page
  5. context-clicked on the page and chose Leo AI Tools >
  6. chose the respective menu-item entry being tested
  7. noted its appropriate output (per menu-item entry) in the Leo sidebar

2. Quick actions - PASSED

Summarize

example example
Screen Shot 2024-03-06 at 1 28 35 PM Screen Shot 2024-03-06 at 1 29 05 PM

Explain

example example
Screen Shot 2024-03-06 at 1 33 24 PM Screen Shot 2024-03-06 at 1 33 44 PM

3. Rewrite - PASSED

Paraphrase

example example
Screen Shot 2024-03-06 at 1 38 45 PM Screen Shot 2024-03-06 at 1 39 21 PM

Improve

example example
Screen Shot 2024-03-06 at 1 51 41 PM Screen Shot 2024-03-06 at 1 51 54 PM

Change tone >

Academic

example example
Screen Shot 2024-03-06 at 1 54 17 PM Screen Shot 2024-03-06 at 1 54 05 PM

Professional

example example
Screen Shot 2024-03-06 at 1 55 43 PM Screen Shot 2024-03-06 at 1 55 54 PM

Persuasive

example example
Screen Shot 2024-03-06 at 1 56 14 PM Screen Shot 2024-03-06 at 1 56 23 PM

Casual

example example
Screen Shot 2024-03-06 at 1 56 39 PM Screen Shot 2024-03-06 at 1 56 46 PM

Funny

example example
Screen Shot 2024-03-06 at 1 57 04 PM Screen Shot 2024-03-06 at 1 57 12 PM

Change length >

Shorten

example example
Screen Shot 2024-03-06 at 2 15 33 PM Screen Shot 2024-03-06 at 2 15 44 PM

Expand

example example
Screen Shot 2024-03-06 at 2 18 09 PM Screen Shot 2024-03-06 at 2 18 35 PM

4. Create - PASSED

Tagline

example example
Screen Shot 2024-03-06 at 2 21 53 PM Screen Shot 2024-03-06 at 2 22 04 PM

Social media >

Short post

example example
Screen Shot 2024-03-06 at 3 11 46 PM Screen Shot 2024-03-06 at 3 09 42 PM

Long post

example example
Screen Shot 2024-03-06 at 3 13 37 PM Screen Shot 2024-03-06 at 3 10 01 PM

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 6, 2024
@stephendonner
Copy link
Collaborator

stephendonner commented Mar 7, 2024 •
edited

Verification PASSED using

Brave | 1.64.97 Chromium: 122.0.6261.111 (Official Build) beta (64-bit)
-- | --
Revision | f7c8f13563bfe1063db456650cb43207e1c960c0
OS | Windows 10 Version 22H2 (Build 19045.4123)

1. Leo AI Tools context-menu invocations (high-level) - PASSED

Opted-out - PASSED

No text highlighted, context-click action

Steps:

  1. installed 1.64.97
  2. launched Brave
  3. loaded skynews.com
  4. context-clicked on an empty region

Confirmed no Leo AI Tools submenu in the invoked context-menu

image

Text highlighted, context-click action

Steps:

  1. installed 1.64.97
  2. launched Brave
  3. loaded a fiercewireless.com link
  4. selected part of the article's body text
  5. context-clicked on the page
  6. chose Explain from the flyout Brave AI tools > menu
  7. clicked I understand in the opened Leo pane

Confirmed Leo AI Tools context-menu item appears, with flyout, in the invoked context-menu

example example example
image image image

Opted-in - PASSED

No text highlighted, context-click action

Steps:

  1. installed 1.64.97
  2. launched Brave
  3. loaded an msn.com/news link
  4. clicked Summarize this page
  5. clicked I understand
  6. context-clicked on an empty region

Confirmed no Leo AI Tools submenu in the invoked context-menu

image

Text highlighted, context-click action

image

Shared Steps:

  1. installed 1.64.97
  2. launched Brave
  3. loaded various pages (see screenshots in each respective section)
  4. selected a portion of the text on the page
  5. context-clicked on the page and chose Leo AI Tools >
  6. chose the respective menu-item entry being tested
  7. noted its appropriate output (per menu-item entry) in the Leo sidebar

2. Quick actions - PASSED

Summarize

example example
image image

Explain

example example
image image

3. Rewrite - PASSED

Paraphrase

example example
image image

Improve

example example
image image

Change tone >

Academic

example example
image image

Professional

example example
image image

Persuasive

example example
image image

Casual

example example
image image

Funny

example example
image image

Change length >

Shorten

example example
image image

Expand

example example
image image

4. Create - PASSED

Tagline

example example
image image

Social media >

Short post

example example
image image

Long post

example example
image image

@stephendonner stephendonner added QA Pass-Win64 QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 7, 2024
@stephendonner
Copy link
Collaborator

stephendonner commented Mar 14, 2024 •
edited

Verification PASSED using

Brave	1.64.104 Chromium: 123.0.6312.46 (Official Build) (64-bit) 
Revision	0ca3d372cf8aab96fafdd75f5c5c8d2012bc0cc6
OS	Linux

1. Leo AI Tools context-menu invocations (high-level) - PASSED

Opted-out - PASSED

No text highlighted, context-click action

Steps:

  1. installed 1.64.104
  2. launched Brave
  3. loaded skynews.com
  4. context-clicked on an empty region

Confirmed no Leo AI Tools submenu in the invoked context-menu

Screen Shot 2024-03-14 at 5 04 36 PM

Text highlighted, context-click action

Steps:

  1. installed 1.64.9104
  2. launched Brave
  3. loaded a fiercewireless.com link
  4. selected part of the article's body text
  5. context-clicked on the page
  6. chose Explain from the flyout Brave AI tools > menu
  7. clicked I understand in the opened Leo pane

Confirmed Leo AI Tools context-menu item appears, with flyout, in the invoked context-menu

example example example
Screen Shot 2024-03-14 at 5 12 31 PM Screen Shot 2024-03-14 at 5 13 03 PM Screen Shot 2024-03-14 at 5 14 25 PM

Opted-in - PASSED

No text highlighted, context-click action

Steps:

  1. installed 1.64.104
  2. launched Brave
  3. loaded a webpage, clicked a link
  4. clicked Summarize this page
  5. clicked I understand
  6. context-clicked on an empty region

Confirmed no Leo AI Tools submenu in the invoked context-menu

Screen Shot 2024-03-14 at 5 18 32 PM

Text highlighted, context-click action

example example
Screen Shot 2024-03-14 at 5 21 03 PM Screen Shot 2024-03-14 at 5 22 18 PM

Shared Steps:

  1. installed 1.64.104
  2. launched Brave
  3. loaded various pages (see screenshots in each respective section)
  4. selected a portion of the text on the page
  5. context-clicked on the page and chose Leo AI Tools >
  6. chose the respective menu-item entry being tested
  7. noted its appropriate output (per menu-item entry) in the Leo sidebar

2. Quick actions - PASSED

Summarize

example example
Screen Shot 2024-03-14 at 5 28 24 PM Screen Shot 2024-03-14 at 5 30 42 PM

Explain

example example
Screen Shot 2024-03-14 at 6 16 48 PM Screen Shot 2024-03-14 at 6 16 58 PM

3. Rewrite - PASSED

Paraphrase

example example
Screen Shot 2024-03-14 at 6 18 55 PM Screen Shot 2024-03-14 at 6 19 16 PM

Improve

example example
Screen Shot 2024-03-14 at 6 20 28 PM Screen Shot 2024-03-14 at 6 22 29 PM

Change tone >

Academic

example example
Screen Shot 2024-03-14 at 6 27 04 PM Screen Shot 2024-03-14 at 6 27 23 PM

Professional

example example
Screen Shot 2024-03-14 at 6 29 25 PM Screen Shot 2024-03-14 at 6 29 43 PM

Persuasive

example example
Screen Shot 2024-03-14 at 6 31 29 PM Screen Shot 2024-03-14 at 6 32 23 PM

Casual

example example
Screen Shot 2024-03-14 at 6 33 17 PM Screen Shot 2024-03-14 at 6 33 34 PM

Funny

example example
Screen Shot 2024-03-14 at 6 35 01 PM Screen Shot 2024-03-14 at 6 35 59 PM

Change length >

Shorten

example example
Screen Shot 2024-03-14 at 6 44 43 PM Screen Shot 2024-03-14 at 6 44 58 PM

Expand

example example
Screen Shot 2024-03-14 at 6 45 14 PM Screen Shot 2024-03-14 at 6 46 03 PM

4. Create - PASSED

Tagline

example example
Screen Shot 2024-03-14 at 6 59 18 PM Screen Shot 2024-03-14 at 6 59 25 PM

Social media >

Short post

example example
Screen Shot 2024-03-14 at 7 01 28 PM Screen Shot 2024-03-14 at 7 01 37 PM

Long post

example example
Screen Shot 2024-03-14 at 7 01 46 PM Screen Shot 2024-03-14 at 7 01 57 PM

@stephendonner stephendonner added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 14, 2024
@LaurenWags LaurenWags mentioned this issue Mar 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yrliou yrliou

Labels
browser-ai OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
Browser AI
Status: Done
Milestone
1.64.x - Release
Development

Successfully merging a pull request may close this issue.

Add more Leo tools in context menu brave/brave-core
5 participants
@stephendonner @kjozwiak @yrliou @LorenzoMinto @brave-builds