Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-load via IPFS notification isn't sticky when loading an IPFS/IPNS page #36347

Closed
srirambv opened this issue Feb 23, 2024 · 3 comments · Fixed by brave/brave-core#22329
Closed

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 23, 2024

Description

Auto-load via IPFS notification isn't sticky when loading an IPFS/IPNS page

Steps to Reproduce

  1. Clean profile
  2. Visit en.wikipedia-on-ipfs.org
  3. Page automatically loads but the notification bar isn't sticky

Actual result:

IPFS.mp4

Expected result:

Should continue to show the notification bar until user selects Always, Only this time or No Thanks

Reproduces how often:

Easy

Brave version (brave://version info)

All

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @cypt4 @vadimstruts

@srirambv
Copy link
Contributor Author

This seems to be an intermittent issue. Wasn't able to repro the issue when testing on macOS

@kjozwiak
Copy link
Member

kjozwiak commented Mar 2, 2024

The above requires 1.64.92 or higher for 1.64.x verification 👍

@srirambv
Copy link
Contributor Author

srirambv commented Mar 6, 2024

Verification passed on

Brave 1.64.95 Chromium: 122.0.6261.94 (Official Build) beta (64-bit)
Revision 6f4193fbcee7c358ae3684f777faa9f12e52206e
OS Windows 11 Version 23H2 (Build 22631.3155)
  • Verified steps from issue description
  • Verified Auto-load via IPFS notification bar is shown until user makes a choice
  • Verified notification bar is shown everytime if user selects Only this time
  • Verified notification bar is not shown everytime if user selects Always or No thanks
36347.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment