Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] New tab takeover iOS video ads #36435

Closed
25 of 27 tasks
tmancey opened this issue Feb 28, 2024 · 3 comments · Fixed by brave/brave-core#22701
Closed
25 of 27 tasks

[ads] New tab takeover iOS video ads #36435

tmancey opened this issue Feb 28, 2024 · 3 comments · Fixed by brave/brave-core#22701

Comments

@tmancey
Copy link
Contributor

tmancey commented Feb 28, 2024

Q1/2024

POC

MVP targeting 1.66.x

PR: brave/brave-core#22701

Backlog:

--

https://github.com/brave/brave-browser/projects/26#column-19787507

@tmancey tmancey added enhancement Epic feature/ads OS/iOS Fixes related to iOS browser functionality labels Feb 28, 2024
@tmancey tmancey added this to Q1/2024 Milestones & Showstoppers in Ads Feb 28, 2024
@aseren aseren self-assigned this Apr 8, 2024
@tmancey tmancey moved this from Q2/2024 Milestones & Showstoppers to Review in Ads Apr 9, 2024
@tmancey tmancey changed the title [ads] New tab takeover video ads [ads] New tab takeover iOS video ads Apr 11, 2024
@kjozwiak
Copy link
Member

kjozwiak commented Apr 16, 2024

The above requires 1.66.81 or higher for 1.66.x verification 👍 @Uni-verse @hffvld the above should also be checked on iOS 15, iOS 16 & iOS 17. We should also verify that everything is working on phones & tablets. I suspect we might find some issues with the videos being stretched out on tablet.

@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 23, 2024
@Uni-verse
Copy link
Contributor

Uni-verse commented Apr 23, 2024

Verified on iPhone running iOS 17.3.1 using version 1.66.104

Test Plan: brave/brave-core#22701 (comment)

Test Case 1:

  • Ensured that video autoplay starts after the tab with New Tab Takeover video ad is opened.
  • Ensured the following during autoplay:
    • CTA logo button is not shown during autoplay
    • Video is muted during autoplay
    • Favorites, Stats, Brave News are visible
  • Ensured the following after autplay is finished:
    • Favorites, Stats, Brave News are still visible
    • CTA logo button fades-in
    • Video play button fades-in
  • Ensured autoplay finishes at frame defined by Stop Frame parameter, which is around 5 seconds
  • Ensured video is played when tapping play button
  • Ensured the following during playback:
    • CTA logo, play button, Favorites, Stats, Brave News fade-out
    • Video playback is started from the beginning
    • Video is played with sound
    • Cancel button appeared in the upper left corner
  • Ensured pausing/un-pausing video works without issues or delays
  • Ensured the following is true after playback is finished:
    • CTA logo, play button, Favorites, Stats, Brave News fade-in
    • The video is paused
    • Cancel button disappears
  • Ensured tapping CTA logo button
  • Ensured page navigates to a landing page with url (https://brave.com/ for staging component)

Test Case 2:

  • Ensured tapping on video before autoplay is finished will start full screen playback.
  • Ensured the following during playback:
    • CTA logo, play button, Favorites, Stats, Brave News fade-out
    • Video playback is started from the beginning
    • Video is played with sound
    • Cancel button appeared in the upper left corner

Test Case 3:

  • Ensured tapping cancel button when more than 50% of playback is reached will close video
  • Ensured the following P3A metrics are recorded based on usage in brave://local-state:
  • creativeInstanceId.views
  • creativeInstanceId.clicks
  • creativeInstanceId.lands
  • creativeInstanceId.media_play
  • creativeInstanceId.media_25
  • creativeInstanceId.media_100

IMG_6114

Test Case 4:

Open new tab with video ad

  • Ensure the following events were logged when video ad is viewed in new tab:

    • [ads] Viewed new tab page ad impression with placement id 36406940-83F2-41BF-81FE-DD01394B9F3B and creative instance id 8946dee6-e50e-4602-b9e4-517b4cda327f
    • [ads] Confirming view for new_tab_page_ad with transaction id 95dcbe0a-4edc-4e1b-9337-81e0ae04184f and creative instance id 8946dee6-e50e-4602-b9e4-517b4cda327f

Screenshot 2024-05-09 at 3 50 23 PM

Playback for video ad

  • Ensured that following events were recorded in logs after pausing video immediately after starting playback:
    • [ads] Started playing new tab page video ad with placement id 36406940-83F2-41BF-81FE-DD01394B9F3B and creative instance id 8946dee6-e50e-4602-b9e4-517b4cda327f
    • [ads] Confirming media_play for new_tab_page_ad with transaction id c7bc408f-0d17-40e4-89de-1b324fc129ba and creative instance id 8946dee6-e50e-4602-b9e4-517b4cda327f
    • [ads] Successfully processed media_play confirmation for new_tab_page_ad with transaction id cb22a7ba-a200-4a76-b1d6-52abc61e9d39 and creative instance id 8946dee6-e50e-4602-b9e4-517b4cda327f

Screenshot 2024-05-09 at 3 49 51 PM

  • Ensured the following events were fired/logged when after video has played more than halfway:

    • [ads] Played 25% of new tab page video ad with placement id 36406940-83F2-41BF-81FE-DD01394B9F3B and creative instance id 8946dee6-e50e-4602-b9e4-517b4cda327f
    • [ads] Confirming media_25 for new_tab_page_ad with transaction id be3a19c8-b278-4529-adb4-49c8dc121086 and creative instance id 8946dee6-e50e-4602-b9e4-517b4cda327f
    • [ads] Successfully processed media_25 confirmation for new_tab_page_ad with transaction id fb70edc5-02ac-4872-b7df-9035feb27c9a and creative instance id 8946dee6-e50e-4602-b9e4-517b4cda327f

Screenshot 2024-05-09 at 3 49 42 PM

  • Ensured the following events were fired/logged when after video has finished playing:

    • [ads] Played 100% of new tab page video ad with placement id 36406940-83F2-41BF-81FE-DD01394B9F3B and creative instance id 8946dee6-e50e-4602-b9e4-517b4cda327f
    • [ads] Confirming media_100 for new_tab_page_ad with transaction id 4085320b-f3d0-48db-b876-d0203626f121 and creative instance id 8946dee6-e50e-4602-b9e4-517b4cda327f
    • [ads] Successfully processed media_100 confirmation for new_tab_page_ad with transaction id d76ec048-3125-49aa-9320-5eab0df7df03 and creative instance id 8946dee6-e50e-4602-b9e4-517b4cda327f

Screenshot 2024-05-09 at 3 49 29 PM

Test Case 5:

  • Ensured Brave News be dragged and feed is visible after autoplay is finished on new tab.
  • Ensured tapping on Favorites on NTP will load url when autoplay is in progress for video NTT.
0

Test Case 6:

  • Ensured that video and Play button is hidden when rotating device to landscape orientation.
  • Ensured CTA logo, Favorites, Stats and Brave News are visible.
  • Ensured video and Play button are shown after opening New Tab in landscape and then switching to portrait mode.
Example Example
IMG_6118 IMG_6119

Test Case 7:

  • Ensured that switching tabs during video autoplay and then return to original tab does not cause issues.
  • Ensured that switching tabs during playback and then returning does not cause issues.
  • Ensured that CTA logo, Favorites, Stats and Brave News are visible when returning to tab with video ad.

Test Case 8:

  • Ensured switching apps/Brave app into background state during autoplay and then returning does not cause issues and video ad is still active.
  • Ensured switching apps/Brave app into background state during full screen playback and then returning does not cause issues.
  • Ensured that video is paused when changing apps.
  • Ensured playback can be resumed by tapping on video after returning to Brave.

@Uni-verse
Copy link
Contributor

Uni-verse commented May 9, 2024

Verified on iPad (7th Gen) running version 7.4.1 using version 1.66.104

Test Case 9:

  • Ensured Video NTT autoplay is enabled.
  • Ensured changing device to landscape orientation does not interrupt video play and no UI issues are observed.
  • Ensured CTA logo, Play button, Favorites, Stats, Brave News are visible when autoplay finishes.
  • Ensured tapping on the play button start full screen playback.
    • Video is played from the beginning.
    • Video is played with sound.
    • Cancel button appears in top right corner.

UI

Example Example Example Example
IMG_1371 IMG_1372 IMG_1365 IMG_1374

Attribution / Rewards

Open Video NTT

Screenshot 2024-05-09 at 5 59 44 PM

Playback

Screenshot 2024-05-09 at 6 00 22 PM

Playback finishes

Screenshot 2024-05-09 at 6 01 17 PM

Tap on Video Sponsor logo

Screenshot 2024-05-09 at 6 06 06 PM

Landed event after 10 secs on sponsor homepage

Screenshot 2024-05-09 at 6 06 18 PM

Case: Disabling background images/sponsored images

  • Ensured Sponsored images and video NTT is not shown when disabling Background Images in New Tab Page settings
  • Ensured changing Image Type to Default Images will not show any sponsored images on NTP.
Example Example Example Example
IMG_1375 IMG_1376 IMG_1377 IMG_1378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Ads
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants