Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct text wrapping on signing confirmation panel #36461

Closed
jamesmudgett opened this issue Feb 29, 2024 · 1 comment · Fixed by brave/brave-core#22399
Closed

Correct text wrapping on signing confirmation panel #36461

jamesmudgett opened this issue Feb 29, 2024 · 1 comment · Fixed by brave/brave-core#22399
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.65.x - Release

Comments

@jamesmudgett
Copy link
Collaborator

jamesmudgett commented Feb 29, 2024 •
edited

visit portfolio.metamask.io and attempt to enable notifications.

Image
@jamesmudgett jamesmudgett added priority/P3 The next thing for us to work on. It'll ride the trains. feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Feb 29, 2024
@Douglashdaniel Douglashdaniel added bug QA/Yes release-notes/include front-end-change This task is a front end task and doesn't need any C++ changes labels Feb 29, 2024
@Douglashdaniel Douglashdaniel mentioned this issue Feb 29, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Feb 29, 2024
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.65.89 Chromium: 123.0.6312.58 (Official Build) beta (64-bit)
Revision 2975bd8d3905ed79de82dd9fa11b6e4019075dd6
OS Windows 11 Version 23H2 (Build 22631.3296)
36461.mp4

@rebron rebron changed the title Correct text wrapping on signing confirmation panel. Correct text wrapping on signing confirmation panel Apr 2, 2024
@LaurenWags LaurenWags mentioned this issue Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.65.x - Release
Development

Successfully merging a pull request may close this issue.

style(wallet): SIWE Error Text Wrapping brave/brave-core
4 participants
@jamesmudgett @srirambv @Douglashdaniel @brave-builds