Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send and Swap panel screen should be same size and buttons should have border on both screens #36505

Closed
srirambv opened this issue Mar 1, 2024 · 1 comment · Fixed by brave/brave-core#22420
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

srirambv commented Mar 1, 2024

Description

Send and Swap screen should be same size and buttons should have border on both screens

Steps to Reproduce

  1. Initiate a Send and Swap transaction
  2. Both transactions have different panel size
  3. Reject button on Send has border while Cancel button on Swap screen doesn't have border

Actual result:

c7XdzW0i2D.mp4

Expected result:

Panel size should be same for both type of transaction and buttons should have border. Maybe also have either Reject or Cancel on both screens

Reproduces how often:

Easy

Brave version (brave://version info)

All

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @Douglashdaniel @kleantzogu

@Douglashdaniel Douglashdaniel self-assigned this Mar 1, 2024
@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label Mar 1, 2024
@srirambv srirambv changed the title Send and Swap screen should be same size and buttons should have border on both screens Send and Swap panel screen should be same size and buttons should have border on both screens Mar 1, 2024
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Mar 1, 2024
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.65.89 Chromium: 123.0.6312.58 (Official Build) beta (64-bit)
Revision 2975bd8d3905ed79de82dd9fa11b6e4019075dd6
OS Windows 11 Version 23H2 (Build 22631.3296)
  • Verified steps from brave/brave-core#22420
  • Verified Send/Swap/Approve panels are of the same size
  • Verified Send/Swap/Approve panels have Reject button, not a Cancel button
  • Verified Send/Swap/Approve panels Reject button is outlined
36505.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants