Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Editing Token Details #36657

Closed
Douglashdaniel opened this issue Mar 8, 2024 · 1 comment · Fixed by brave/brave-core#22555
Closed

Allow Editing Token Details #36657

Douglashdaniel opened this issue Mar 8, 2024 · 1 comment · Fixed by brave/brave-core#22555
Assignees
@Douglashdaniel
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.65.x - Release

Comments

@Douglashdaniel
Copy link

Description

We need to allow editing Token details just like we allow with NFT's
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Mar 8, 2024
@Douglashdaniel Douglashdaniel self-assigned this Mar 8, 2024
@Douglashdaniel Douglashdaniel mentioned this issue Mar 12, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Mar 13, 2024
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.65.89 Chromium: 123.0.6312.58 (Official Build) beta (64-bit)
Revision 2975bd8d3905ed79de82dd9fa11b6e4019075dd6
OS Windows 11 Version 23H2 (Build 22631.3296)
  • Verified steps from brave/brave-core#22555
  • Verified native tokens can't be edited
  • Verified token details can be edited via more menu
36657.mp4

@LaurenWags LaurenWags mentioned this issue Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.65.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Allow Editing Token Details brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds